add exact match reward, make_reward_fn wrapper, remove check_answer from default rewards#3443
Open
add exact match reward, make_reward_fn wrapper, remove check_answer from default rewards#3443
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
A9isha
reviewed
Mar 20, 2026
A9isha
reviewed
Mar 20, 2026
A9isha
reviewed
Mar 20, 2026
| except (TimeoutException, Exception): | ||
| pass | ||
|
|
||
| # Correct answer gets tmvp_config.reward_exact_format_match points! |
Collaborator
There was a problem hiding this comment.
since this becomes the primary reward function now and we are skipping check_numbers() by default, could you please bring the debug logic from check_numbers() from here. This really helps in debugging extraction logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
add exact match reward, make_reward_fn wrapper, remove check_answer from default rewards
check_answer has significant overlap with check_numbers and overlapping reward coefficients, so am commenting it out for simplicity by default.
I added make_reward_fn wrapper so that logging in tunix can see the name of the reward fn, instead of overwriting for each.
Tests
Please describe how you tested this change, and include any instructions and/or
commands to reproduce.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.