Conversation
xibinliu
requested review from
A9isha,
NicoGrande,
NuojCheng,
RissyRan,
SurbhiJainUSC,
aireenmei,
bvandermoon,
dipannita08,
gagika,
gobbleturk,
hengtaoguo,
igorts-git,
jacoguzo,
jesselu-google,
jiangjy1982,
khatwanimohit,
parambole,
richjames0,
shralex,
suexu1025 and
vipannalla
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Also move http://github.com/AI-Hypercomputer/maxtext/blob/main/tests/unit/rl_utils_test.py to post_train
| export MAXTEXT_NOTEBOOKS_ROOT="$MAXTEXT_REPO_ROOT/src/maxtext/examples" | ||
|
|
||
| # Install dependencies for running notebooks | ||
| $PYTHON_EXE -m pip install papermill ipykernel ipywidgets |
There was a problem hiding this comment.
Do we need to install these notebook dependencies? Are these not already present in post-train-requirements.txt?
There was a problem hiding this comment.
Removed this line. Thanks for catching this.
xibinliu
force-pushed
the
xibin/ci
branch
2 times, most recently
from
a662345 to
a2e7b47
Compare
This file is called by build_and_test_maxtext.yml to run tpu/cpu/gpu unit and integration tests. It simplifies the caller's input.
| pip_deps: "" | ||
| - flavor: tpu-integration | ||
| pip_deps: "" | ||
| - flavor: post-training-tpu-unit |
There was a problem hiding this comment.
For consistency, let's rename this to tpu-post-training-unit
| include: | ||
| - flavor: cpu-unit | ||
| pip_deps: "" | ||
| - flavor: post-training-cpu-unit |
There was a problem hiding this comment.
same: cpu-post-training-unit
| export MAXTEXT_PKG_DIR=$(pwd)/src/maxtext | ||
| export MAXTEXT_NOTEBOOKS_ROOT="$MAXTEXT_REPO_ROOT/src/maxtext/examples" | ||
|
|
||
| # Install dependencies for running notebooks |
There was a problem hiding this comment.
This comment is wrong. We are actually registering the venv to the kernel, right?
| "post-training-cpu-unit": "cpu_only" | ||
| }')[inputs.flavor] }} | ||
|
|
||
| pytest_extra_args: >- |
There was a problem hiding this comment.
Why do we need this when we have already added not post_training marker to tpu unit tests at line 107?
2 participants
Description
Refactor the current workflow code.
Add run_tests_coordinator.yml file.
This file is called by build_and_test_maxtext.yml to run tpu/cpu/gpu unit and integration tests.
It simplifies the caller's inputs.
Tests
See this PR's workflow action runs.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.