Force layout on Q for MLA when use_jax_splash=True #2986
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
requested review from
A9isha,
NicoGrande,
NuojCheng,
RissyRan,
SurbhiJainUSC,
aireenmei,
bvandermoon,
gagika,
gobbleturk,
hengtaoguo,
jesselu-google,
jiangjy1982,
khatwanimohit,
parambole,
richjames0,
shralex,
shuningjin,
suexu1025 and
vipannalla
as code owners
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
copybara-service
bot
force-pushed
the
test_855382451
branch
2 times, most recently
from
b0ed511 to
4386083
Compare
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
test_855382451
branch
2 times, most recently
from
f7d8cf3 to
762ac72
Compare
copybara-service
bot
force-pushed
the
test_855382451
branch
from
762ac72 to
fbef426
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Force layout on Q for MLA when use_jax_splash=True
This helps in non-pallas splash attention and removes copies when num_heads is 128.
major to minor layout
original query: 1, 2, 192, 1024, 128
attention expectation: 1, 2, 128, 192 , 1024
This change speedups up non-pallas forward splash attention upto 14%.