Skip to content

[src/MaxText/inference/offline_engine.py] Make OfflineEngine a fluent interface #2983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SamuelMarks wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[src/MaxText/inference/offline_engine.py] Make OfflineEngine a fluent interface #2983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/MaxText/experimental/rl/grpo_trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
import functools
import threading

from copy import deepcopy
from typing import Sequence, Callable, Iterator

from absl import app
Expand Down Expand Up @@ -691,10 +692,9 @@ def train_loop(config, config_inference, recorder, state=None):

data_sharding = sharding.get_input_data_sharding(config, mesh)

inference_engine = offline_engine.OfflineEngine(
config=config_inference,
mesh=inference_mesh,
)
config = deepcopy(config_inference)
config.mesh = inference_mesh
inference_engine = offline_engine.OfflineEngine(config=config)
data_buffer = []
data_buffer_lock = threading.Lock()

Expand Down
Loading
Loading