More robust splicing edge cases - #3366
Merged
Merged
Conversation
We apply some defense-in-depth to better handle edge cases during splicing where a remote peer doesn't follow the BOLTs. This also includes more thorough pattern-matching, which protects against future refactoring or new features from inadvertently introducing a vulnerability related to splicing.
When we were selling liquidity and abort the funding attempt after telling our peer actor that the purchase was signed, we must send it a LiquidityPurchaseAborted event. Otherwise the payment stays in the Funded state, pointing at a funding transaction that will never exist: we hold the upstream HTLCs until they expire, at which point we force-close a channel that we aborted the splice on ourselves.
sstone
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We apply some defense-in-depth to better handle edge cases during splicing where a remote peer doesn't follow the BOLTs. This also includes more thorough pattern-matching, which protects against future refactoring or new features from inadvertently introducing a vulnerability related to splicing.