Skip to content

Improvements in PeerScorer - #3365

Open
pm47 wants to merge 3 commits into
masterfrom
scoring-nits
Open

Improvements in PeerScorer#3365
pm47 wants to merge 3 commits into
masterfrom
scoring-nits

Conversation

@pm47

@pm47 pm47 commented Aug 25, 2026

Copy link
Copy Markdown
Member

This is mainly consistency improvements in logging.

Also made min/max proportional relay fee reconfigurable while the node is running.

Commits are independent.

@pm47
pm47 requested a review from t-bast August 25, 2026 13:51
}

if (!config.relayFees.autoUpdate) {
log.info("not closing channels: auto-close is disabled")

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: wrong copy-paste

case Some(u) =>
val next = u.relayFees.copy(feeProportionalMillionths = (u.feeProportionalMillionths - 500).max(config.relayFees.minRelayFees.feeProportionalMillionths))
Some(p.remoteNodeId -> FeeChangeDecision(FeeDecrease, u.relayFees, next, p.dailyVolumeOut))
Some(p.remoteNodeId -> FeeChangeDecision(FeeDecrease, u.relayFees, next, p.dailyVolumeOut, volumeVariation = 0))

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is volumeVariation hard-coded to 0 here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants