Complete coverage for branching.py#219
Merged
tennlee merged 6 commits intoACCESS-Community-Hub:developfrom Nov 14, 2025
Merged
Conversation
Pull Request Test Coverage Report for Build 19347476561Details
💛 - Coveralls |
Collaborator
Author
|
ok these tests were pretty tricky for me so i'm just a bit demoralized that total coverage has only gone up 0.1% 🥲 |
Collaborator
|
Yeah it's hard! I have the same feeling - I enjoy the big wins a lot more than the little gains (in terms of % covered) but often it's the niggly specific things which are actually more essential. Branching is a really core part of how the pipelines work, and is tricky, so I super-appreciate it. Also, PET has a lot of lines of code, so even a big change is still going to be like 0.3% or something. |
Collaborator
|
Thanks! Looks great! Much appreciated, great to get the test coverage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This covers the last handful of statements that were not or partially covered.
no coversince the false case is never reached.check_if_indextmp function to make it easier to test.