Open
Conversation
Contributor
|
Nice :) This could be useful for typescript ppl. For it to be really useful, I think it's necessary to cover the whole API schema with proper types (as you have for basket and release) before merging and releasing. |
Contributor
Author
|
agreed, I'm also wondering/looking at if I can put in some tests/checks to make sure it doesn't get out of date. There's an issue that the new usage types parameter actually affects the schema. Seeing as this is the future of the api, maybe we should think about forcing the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skeleton typescript typings. Apart from Basket and Release, which has been done manually with proper types, these were generated from the script below: