Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes improvements to the
stackchan_server/ws_proxy.pymodule to enhance configurability and fix directory creation logic. The most important changes are grouped below:Configuration Improvements:
create_voicevox_clientfunction now allows the Voicevox server URL to be set via theSTACKCHAN_VOICEVOX_URLenvironment variable, making it easier to configure the server location without modifying code.Directory Management Fixes:
recordingsdirectory is now only created when debug recording is enabled, preventing unnecessary directory creation. The logic for creating the directory has been moved from the module level to theWsProxyclass's initialization, ensuring it is only created when needed. [1] [2]