Change target selector to get correct ::before#8
Open
Thenakedgun wants to merge 1 commit into5t3ph:mainfrom
Open
Change target selector to get correct ::before#8Thenakedgun wants to merge 1 commit into5t3ph:mainfrom
Thenakedgun wants to merge 1 commit into5t3ph:mainfrom
Conversation
When I trialed this example, I didn't see the text "Is it me you're looking for?" as the example would suggest, but instead "Aww, you came to see me!" This second string seems to come from the normal "style.css" file & didn't have anything to do with the example. I think to make this work, you'd need to change .smol-article-anchor:target::before to #smol-article-anchor-title:target::before. I don't use GitHub much, so please forgive me if the way I've suggested this is abnormal; just tried to suggest the change via their UI. I got a link to your site from Kevin Powell's newsletter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I trialed this example, I didn't see the text "Is it me you're looking for?" as the example would suggest, but instead "Aww, you came to see me!" This second string seems to come from the normal "style.css" file & didn't have anything to do with the example. I think to make this work, you'd need to change
.smol-article-anchor:target::beforeto#smol-article-anchor-title:target::before.I don't use GitHub much, so please forgive me if the way I've suggested this is abnormal; just tried to suggest the change via their UI. I got a link to your site from Kevin Powell's newsletter.