feature: add chat sound mute toggle#411
Open
zeeshaun wants to merge 4 commits into
Open
Conversation
Contributor
|
can you also add auto mute when they are in a match and in game? |
feafee5 to
eea0289
Compare
Contributor
|
let me know when its ready , so far it looks good , not sure what testing you need todo etc |
Author
|
I tested in the browser using devtools and added a vitest unit test. I did not have a server spin up locally and test though. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Adds a chat sound mute toggle to chat surfaces so players can silence incoming chat notifications while staying in chat.
Changes
useSound()state across callers so the toggle and notification playback use the same enabled state.chat-sound-enabledlocalStorage key.Validation
localStorage.chat-sound-enabledtofalseand persists after refresh.Change was tested locally through the running Tilt dev stack.