Conversation
driccio
approved these changes
Feb 21, 2023
Member
driccio
left a comment
There was a problem hiding this comment.
Thanks for your work.
Not your fault but I don't get why -v is a suboption of a command. Would have been better to have it as a global option.
Contributor
Author
|
Agree, i will move -v and -vv as a global config in this PR. |
+ add option trace
replace by a custom code that print if a test succeeded or not and print a summary
…throw an exception instead
Unit Test Results 60 files - 1 60 suites - 1 3m 43s ⏱️ +46s Results for commit a39846a. ± Comparison against base commit 9e94312. This pull request removes 11 and adds 11 tests. Note that renamed tests count towards both. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verbose and trace (verbose ++) are a logger level, now every class can use it. Some log are modify, like normal mode print less (no config, summary print only executed script, …), driver print, trace can print shell command used for mongo cli and stdout of the command, …
porcelain is managed by cli module and not by core and other modules
Resolve #195