Skip to content

Simplify parsing of of latitude and longitude data #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ali-cetin-4ss wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Simplify parsing of of latitude and longitude data #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions fourinsight/campaigns/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,16 +166,17 @@ def get_campaigns(self):

response = self._get_payload(self._url(""))

location_keys = ["location", "geolocation"]
for campaign_item in response:
for key in campaign_item.keys():
if key.lower() in location_keys:
campaign_item[key] = _location_convert(campaign_item[key])

response_out = [
_dict_rename(campaign_item, response_map) for campaign_item in response
]

for campaign_item in response_out:
campaign_item.update(
{
key: _location_convert(campaign_item[key])
for key in ["Location", "GeoTrack Location"]
}
)
return response_out

def get_campaign(self, campaign_id):
Expand Down Expand Up @@ -212,11 +213,8 @@ def get_campaign(self, campaign_id):
self._url(f"/{campaign_id}", api_version="v1.0"),
)

for key in response.keys():
if key.lower() in "location":
response[key] = _location_convert(response[key])

response_out = _dict_rename(response, response_map)
response_out["Location"] = _location_convert(response_out["Location"])
return response_out

def get_geotrack(self, campaign_id):
Expand Down