Skip to content

omit placeholders for external identifiers#491

Open
olli-gold wants to merge 1 commit into4Science:dspace-cris-2023_02_xfrom
tubhh:orcid_push_omit_placeholders
Open

omit placeholders for external identifiers#491
olli-gold wants to merge 1 commit into4Science:dspace-cris-2023_02_xfrom
tubhh:orcid_push_omit_placeholders

Conversation

@olli-gold
Copy link

References

Description

This PR solves the problem, that a placeholder may be submitted to ORCID.

Instructions for Reviewers

The problem occurs, when you want to push an item to ORCID.

List of changes in this PR:

  • Omit an external ID if it's just a placeholder

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
  • My PR passes Checkstyle validation based on the Code Style Guide.
  • My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
  • My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR modifies REST API endpoints, I've opened a separate REST Contract PR related to this change.
  • If my PR includes new configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had
activity in one year. It will be closed in 14 days if no further activity occurs.

Allowing pull requests to close as stale helps us filter out old work that is no longer
relevant and helps developers focus on reviewing current work.

All pull requests closed by this bot act like normal pull requests;
they can be searched for, commented on or reopened at any point.

If these changes are still relevant then please comment and/or rebase your PR based on the
latest DSpace code. This will remove the stale status and notify us to assign a reviewer
for your PR.

@github-actions github-actions bot added the stale label Feb 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant