Skip to content

comments in template files#470

Open
floriangantner wants to merge 1 commit into4Science:dspace-cris-2023_02_xfrom
uniba-ub:issue-466
Open

comments in template files#470
floriangantner wants to merge 1 commit into4Science:dspace-cris-2023_02_xfrom
uniba-ub:issue-466

Conversation

@floriangantner
Copy link

@floriangantner floriangantner commented Oct 15, 2024

References

Add references/links to any related issues or PRs. These may include:

Description

Add possibility to add one-line comments # in the template files

Instructions for Reviewers

  • apply some template file with comments starting with #
  • the lines should not be applied in the generated template xml file

List of changes in this PR:

  • add rule to skip lines starting with #
  • also the lines are trimmed, so whitespaces are considered

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
  • My PR passes Checkstyle validation based on the Code Style Guide.
  • My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
  • My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR modifies REST API endpoints, I've opened a separate REST Contract PR related to this change.
  • If my PR includes new configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@floriangantner floriangantner removed their assignment Oct 28, 2024
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had
activity in one year. It will be closed in 14 days if no further activity occurs.

Allowing pull requests to close as stale helps us filter out old work that is no longer
relevant and helps developers focus on reviewing current work.

All pull requests closed by this bot act like normal pull requests;
they can be searched for, commented on or reopened at any point.

If these changes are still relevant then please comment and/or rebase your PR based on the
latest DSpace code. This will remove the stale status and notify us to assign a reviewer
for your PR.

@github-actions github-actions bot added the stale label Feb 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant