feat(api): add peer management to admin RPC - #86
Open
317787106 wants to merge 8 commits into
Open
Conversation
…fo; use parseIpSocketAddress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds runtime peer management to the Admin JSON-RPC API over both HTTP and IPC. It introduces
admin_addPeer,admin_removePeer,admin_disconnectPeer,admin_listActivePeers,admin_blockIp,admin_unblockIp, andadmin_listBlockedIps.Active nodes can be added or removed without restarting the node, while an exact peer connection can be disconnected independently. Manually blocked IPs are persisted in
CommonStoreunderblocked-ips, loaded before libp2p starts, applied to TCP connections, and exposed through the Admin API. Invalid persisted data is deleted on a best-effort basis and does not prevent network startup.The active-peer response reuses the immutable statistics used by
PeerConnection.log(), including connection, latency, and synchronization state. Peer and blocked-IP mutations share one structuredPeerOperationResultresponse.Why are these changes required?
Operators need a way to react immediately after identifying a malicious peer: disconnecting or blocking it cuts the attack path, while adding a trusted endpoint restores useful connectivity without restarting the node. This helps preserve synchronization, block production, and message propagation during Sybil or isolation attacks.
Behavior notes
admin_addPeeradds an active node but does not add it totrustNodes.node.dynamicConfig.enableis enabled, add/remove active-node operations return a structured failure directing operators to updatenode.activeinstead.Testing
checkstyleMain,checkstyleTest, and the related framework test suites pass.Follow-up
Use the released libp2p version after the dependent PR is merged; UDP discovery filtering can be considered in a later phase.
Extra details
Depends on libp2p PR #6. No protobuf, P2P wire-message, consensus, or chain-data format changes are introduced.