Detect middleware runtime and conditionally handle Node middleware for Cloudflare build#1
Draft
314systems wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
useNodeMiddlewarewithdetectMiddlewareRuntimewhich returns one of"edge","node", or"none"by inspecting compiled Next output manifests.build.tsto calldetectMiddlewareRuntimeand to log an informational message when Node middleware is detected instead of erroring and exiting.next-serverAST patching so thedisableNodeMiddlewareRuleis applied only for Next.js versions less than15.5.0usingcompareSemver.middleware.spec.tsunit tests fordetectMiddlewareRuntimeand updated related imports and comments explaining why internal patches remain in place.Testing
vitest, including the newpackages/cloudflare/src/cli/build/utils/middleware.spec.ts, and all tests passed.next-serverpatches were executed and succeeded under the test suite.Codex Task