fix: reject invalid attachment salt hex instead of silent fallback#187
Open
fix: reject invalid attachment salt hex instead of silent fallback#187
Conversation
Replace unwrap_or_else fallback with explicit AttachmentEncryption error at both salt decode sites (restore_attachment and SubtreeRestore undo). Closes #176
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unwrap_or_elsefallback onhex::decodeof attachment salt inrestore_attachment()andSubtreeRestoreundo path — malformed hex now returns an explicitAttachmentEncryptionerror instead of silently using wrong key materialrestore_attachmentwith an invalid salt hex string returnsAttachmentEncryptionTest plan
cargo test -p krillnotes-core— 629 tests pass (1 new)test_restore_attachment_rejects_invalid_salt_hexwould have failed before the fix (fallback swallowed the bad salt)Closes #176