[codex] Add RAG knowledge UI and vector backend scaffold#12
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3b5750c834
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| top_k: int = 5, | ||
| min_score: float = 0.05, | ||
| ) -> list[RagSearchResult]: | ||
| _ = index |
There was a problem hiding this comment.
Filter Chroma queries to the active index
When RAG_VECTOR_BACKEND=chroma, rebuilding an index after removing a document (or using different index_path values through the API) leaves the old chunk ids in the persistent Chroma collection because upsert_index only upserts current chunks and query discards the index argument. A backend-vector search can therefore return stale chunks from documents that are no longer in the active JSON index, corrupting the source context and eval results; delete/replace stale ids or constrain the Chroma query to the current index's chunk ids/document hashes.
Useful? React with 👍 / 👎.
What changed
Boundary
This stops before P7. Chroma is an optional adapter scaffold using the current local hash embedding provider by default; production embedding providers remain planned.
Validation