Skip to content

feat: Migrate to MinIO SDK and enhance S3 client with TLS and context#12207

Open
HynoR wants to merge 2 commits into1Panel-dev:dev-v2from
HynoR:f/s3v10
Open

feat: Migrate to MinIO SDK and enhance S3 client with TLS and context#12207
HynoR wants to merge 2 commits into1Panel-dev:dev-v2from
HynoR:f/s3v10

Conversation

@HynoR
Copy link
Contributor

@HynoR HynoR commented Mar 18, 2026 •
edited
Loading

What this PR does / why we need it?

#11698

Summary of your change

彻底移除 aws-go-sdk 这个 v1 大史山。用 minio-go 替代
minio-go 已经实现了兼容 aws s3的细节,可以直接用于 s3 服务，无论是三方和官方都支持，除了部分高级功能（1panel 目前版本也没实现这接口）不兼容以外。

已经测了 部分 s3 上游（包括亚马逊 S3 官方）使用 minio 的可行性 全部测试无误后转正式 pr

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

HynoR added 2 commits March 18, 2026 11:25
@HynoR
chore: update dependencies and migrate S3 client to MinIO SDK
d0f5ecb 
- Removed AWS SDK dependency and replaced S3 client implementation with MinIO SDK.
- Updated various dependencies in go.mod and go.sum, including version upgrades for `klauspost/compress`, `minio/minio-go`, and `rs/xid`.
- Adjusted S3 client methods to utilize MinIO's API for bucket listing, object existence checks, uploads, downloads, and deletions.
@HynoR
refactor: enhance S3 client with context management and TLS support
8bb93a4 
- Introduced context management with timeouts for S3 client operations to improve reliability.
- Added TLS configuration to support secure connections based on the endpoint scheme.
- Updated S3 client methods to utilize the new context and transport settings for enhanced performance and security.
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Mar 18, 2026

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Mar 18, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zhengkunwang223 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@HynoR HynoR marked this pull request as ready for review March 19, 2026 03:17
@HynoR
Copy link
Contributor Author

HynoR commented Mar 19, 2026

image image

google cloud storage
image

aws s3
image

huawei cloud
telegram-cloud-photo-size-5-6186066221799771641-w

测试已通过

@HynoR
Copy link
Contributor Author

HynoR commented Mar 19, 2026

等你们 claw 那边没需求了再来合并 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wanghe-fit2cloud wanghe-fit2cloud Awaiting requested review from wanghe-fit2cloud

@zhengkunwang223 zhengkunwang223 Awaiting requested review from zhengkunwang223

Assignees

No one assigned

Labels

do-not-merge/release-note-label-needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@HynoR