fix: capture session_id for multi-turn resume and remove output duplication#3
Merged
fix: capture session_id for multi-turn resume and remove output duplication#3
Conversation
…rite Refactor the cherry-picked PR #1 changes: - Extract parseSessionId() into stream-parser.ts alongside existing parsers - Remove tryCaptureFinalText closure and fs.writeFile overwrite that destroyed incremental output - Add 8 tests for parseSessionId and updateSession behavior Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
session_idfrom Claude Code's stream-json output and persist it viaupdateSession, enabling--resumeon subsequent jobs in the same sessionclaude_code_statusthat re-appended all output already captured by the streaming watcherBased on PR #1 by @ZhangYiqun018, with the following:
parseSessionId()instream-parser.ts(consistent with existingparseRateLimitError/parseAuthErrorpattern)tryCaptureFinalText+fs.writeFileoverwrite that replaced incremental output with only the last assistant messageTest plan
npm test— 198 tests pass (8 new)session_idappears in logs--resumeis passed