don't hardcode the Cellar path, use the env variable#65
Open
i3d wants to merge 2 commits into13-CF:masterfrom
Open
don't hardcode the Cellar path, use the env variable#65i3d wants to merge 2 commits into13-CF:masterfrom
i3d wants to merge 2 commits into13-CF:masterfrom
Conversation
Owner
|
Is changing the install to ~/.local a good idea? I don't think ~/.local/bin is in $PATH by default on lots of systems. |
Contributor
It's a bad idea. If you want to overwrite the install path with something less standard than $ make install PREFIX="$HOME"/.local
$ make uninstall PREFIX="$HOME"/.local |
Contributor
|
I suggest not printing an error message when the Cellar ENV var is not found and simply falling back to the original behavior |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would work always for various different installation configurations. It even works for Homebrew for other platforms like linuxbrew.