chore: Incremental account codes pruning - #2463
Open
sergerad wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2444.
The vault and storage prunes are incremental: each block only visits rows that expired since the previous prune. The account-code prune instead re-scanned every account row still valid past the cutoff on every block.
This PR makes the codes prune churn-driven. A code pinned at one prune can only become collectable at a later one if its last referencing row expired between the two cutoffs, so the prune scans just that window for candidates and probes each for a surviving reference — O(churn) per block, like the other two prunes.
Implementation notes:
005addsidx_accounts_code_probe(backs the existence probe) and a single-rowprune_progresstable recording the cutoff through which code pruning has completed. The marker is updated in the same transaction as the prune, so it is crash-consistent and survives restarts.prune_tip), the prune now skips entirely instead of re-scanning the live set.Changelog