refactor: use slices.Contains to simplify code

Signed-off-by: nuxtreact <nuxtreact@outlook.com>

Author: nuxtreact

app/ante/vesting.go

@@ -1,6 +1,8 @@
 package ante
 
 import (
+	"slices"
+
 	errorsmod "cosmossdk.io/errors"
 	sdk "github.com/cosmos/cosmos-sdk/types"
 	sdkerrors "github.com/cosmos/cosmos-sdk/types/errors"
@@ -35,14 +37,12 @@ func (vad VestingAccountDecorator) AnteHandle(
 	for _, msg := range tx.GetMsgs() {
 		typeURL := sdk.MsgTypeURL(msg)
 
-		for _, disabledTypeURL := range vad.disabledMsgTypeURLs {
-			if typeURL == disabledTypeURL {
-				return ctx, errorsmod.Wrapf(
-					sdkerrors.ErrUnauthorized,
-					"MsgTypeURL %s not supported",
-					typeURL,
-				)
-			}
+		if slices.Contains(vad.disabledMsgTypeURLs, typeURL) {
+			return ctx, errorsmod.Wrapf(
+				sdkerrors.ErrUnauthorized,
+				"MsgTypeURL %s not supported",
+				typeURL,
+			)
 		}
 	}
 

cmd/zetaclientd/utils.go

@@ -3,6 +3,7 @@ package main
 import (
 	"context"
 	"os"
+	"slices"
 	"strconv"
 
 	"github.com/pkg/errors"
@@ -22,10 +23,8 @@ func isObserverNode(ctx context.Context, zc *zetacore.Client) (bool, error) {
 
 	operatorAddress := zc.GetKeys().GetOperatorAddress().String()
 
-	for _, observer := range observers {
-		if observer == operatorAddress {
-			return true, nil
-		}
+	if slices.Contains(observers, operatorAddress) {
+		return true, nil
 	}
 
 	return false, nil

cmd/zetae2e/local/monitor_priority_txs.go

@@ -3,6 +3,7 @@ package local
 import (
 	"context"
 	"errors"
+	"slices"
 	"strings"
 	"time"
 
@@ -102,13 +103,7 @@ func isMsgTypeURLSystemTx(attr types.EventAttribute) bool {
 		"\"/zetachain.zetacore.observer.MsgVoteBlame\"",
 	}
 
-	for _, url := range systemTxsMsgTypeUrls {
-		if url == attr.Value {
-			return true
-		}
-	}
-
-	return false
+	return slices.Contains(systemTxsMsgTypeUrls, attr.Value)
 }
 
 func isActionNonSystemTx(attr types.EventAttribute) bool {

rpc/namespaces/ethereum/eth/filters/utils.go

@@ -2,6 +2,7 @@ package filters
 
 import (
 	"math/big"
+	slices0 "slices"
 
 	"github.com/ethereum/go-ethereum/common"
 	ethtypes "github.com/ethereum/go-ethereum/core/types"
@@ -37,13 +38,7 @@ Logs:
 			continue
 		}
 		for i, sub := range topics {
-			match := len(sub) == 0 // empty rule set == wildcard
-			for _, topic := range sub {
-				if log.Topics[i] == topic {
-					match = true
-					break
-				}
-			}
+			match := slices0.Contains(sub, log.Topics[i])
 			if !match {
 				continue Logs
 			}

x/crosschain/keeper/cctx.go

@@ -1,6 +1,8 @@
 package keeper
 
 import (
+	"slices"
+
 	"cosmossdk.io/store/prefix"
 	storetypes "cosmossdk.io/store/types"
 	sdk "github.com/cosmos/cosmos-sdk/types"
@@ -47,14 +49,7 @@ func (k Keeper) updateInboundHashToCCTX(
 ) {
 	in, _ := k.GetInboundHashToCctx(ctx, cctx.InboundParams.ObservedHash)
 	in.InboundHash = cctx.InboundParams.ObservedHash
-	found := false
-	for _, cctxIndex := range in.CctxIndex {
-		if cctxIndex == cctx.Index {
-			found = true
-			break
-		}
-	}
-	if !found {
+	if !slices.Contains(in.CctxIndex, cctx.Index) {
 		in.CctxIndex = append(in.CctxIndex, cctx.Index)
 	}
 	k.SetInboundHashToCctx(ctx, in)

x/observer/keeper/observer_set.go

@@ -1,6 +1,8 @@
 package keeper
 
 import (
+	"slices"
+
 	"cosmossdk.io/errors"
 	"cosmossdk.io/store/prefix"
 	sdk "github.com/cosmos/cosmos-sdk/types"
@@ -29,12 +31,7 @@ func (k Keeper) IsAddressPartOfObserverSet(ctx sdk.Context, address string) bool
 	if !found {
 		return false
 	}
-	for _, addr := range observerSet.ObserverList {
-		if addr == address {
-			return true
-		}
-	}
-	return false
+	return slices.Contains(observerSet.ObserverList, address)
 }
 
 // AddObserverToSet adds an observer to the observer set.It makes sure the updated observer set is valid.