@@ -62,6 +62,11 @@ def add_env( # pylint: disable=too-many-arguments
6262 sub_commands = None ):
6363 # type: (str, object, bool, type, str, List[str]) -> None
6464 """Add environment variable"""
65+ """ env_name: Environment variable name"""
66+ """ default: Default value"""
67+ """ value_type: type of value e.g. str"""
68+ """ dest: attribute name to be return by parse_*"""
69+ """ sub_commands: List of subcommands that use this environment"""
6570 if not dest :
6671 dest = env_name .lower ()
6772 if env_name in self .env_def :
@@ -76,7 +81,10 @@ def add_env( # pylint: disable=too-many-arguments
7681
7782 def has_common_argument (self , option_string = None , dest = None ):
7883 # type: (str, str) -> bool
79- """Whether this parser parses this common argument"""
84+ """Has the parser defined this argument as a common argument?"""
85+ """ Either specify option_string or dest"""
86+ """ option_string: option in command line. e.g. -i"""
87+ """ dest: attribute name to be return by parse_*"""
8088 for action in self .parent_parser ._actions : # pylint: disable=W0212
8189 if option_string :
8290 if option_string in action .option_strings :
@@ -115,7 +123,7 @@ def parse_args(self, args=None, namespace=None):
115123 return result
116124
117125 @staticmethod
118- def is_env_valid (env_name , env_value , env_data , args ):
126+ def _is_env_valid (env_name , env_value , env_data , args ):
119127 # type (str, str, dict, argparse.Namespace) -> bool
120128 """The invalid env should be skipped or raise error"""
121129 # Skip when the env is NOT in the list of supported sub-commands
@@ -141,7 +149,7 @@ def parse_env(self, args=None):
141149 env_data = self .env_def [env_name ]
142150 env_value = os .environ .get (env_name )
143151 try :
144- if not ZanataArgParser .is_env_valid (
152+ if not ZanataArgParser ._is_env_valid (
145153 env_name , env_value , env_data , args ):
146154 continue
147155 except AssertionError as e :
0 commit comments