Merge pull request #130 from ysugimoto/eslint

ESLint integration

Author: 1000ch

.eslintrc

@@ -1,3 +1,5 @@
+parser: babel-eslint
+
 env:
   amd: true
   es6: true
@@ -38,7 +40,7 @@ rules:
   # Best Practices
   accessor-pairs: 2
   block-scoped-var: 0
-  complexity: [2, 6]
+  complexity: 2
   consistent-return: 0
   curly: 0
   default-case: 0
@@ -51,7 +53,6 @@ rules:
   no-case-declarations: 2
   no-div-regex: 2
   no-else-return: 0
-  no-empty-label: 2
   no-empty-pattern: 2
   no-eq-null: 2
   no-eval: 2

.jshintrc

@@ -31,7 +31,7 @@ class ImageResizer {
         return new Promise((resolve, reject) => {
             console.log("Resizing to: " + (this.options.directory || "in-place"));
 
-            var img = gm(image.data).geometry(this.options.size.toString());
+            let img = gm(image.data).geometry(this.options.size.toString());
             if ( "orientation" in this.options ) {
                 img = img.autoOrient();
             }
@@ -42,7 +42,7 @@ class ImageResizer {
               img = img.background(this.options.background).flatten();
             }
             if ( "crop" in this.options ) {
-                var cropArgs = this.options.crop.match(cropSpec);
+                const cropArgs = this.options.crop.match(cropSpec);
                 const cropWidth = cropArgs[1];
                 const cropHeight = cropArgs[2];
                 const cropX = cropArgs[3];

lib/ImageResizer.js

@@ -19,6 +19,8 @@
     "test": "nyc ava",
     "test-config": "./bin/configtest",
     "test-lambda": "claudia test-lambda --profile $npm_package_config_profile --event $npm_config_event_file",
+    "pretest": "npm run lint",
+    "lint": "eslint .",
     "destroy": "AWS_PROFILE=$npm_package_config_profile claudia destroy --profile $npm_package_config_profile"
   },
   "keywords": [
@@ -53,9 +55,11 @@
   "devDependencies": {
     "ava": "^0.18.2",
     "aws-sdk-mock": "^1.6.1",
+    "babel-eslint": "^7.2.1",
     "bind-all": "^1.0.0",
     "claudia": "^2.9.0",
     "coveralls": "^2.12.0",
+    "eslint": "^3.18.0",
     "nyc": "^10.1.2",
     "pify": "^2.3.0",
     "sinon": "^1.17.7"

package.json

@@ -16,25 +16,21 @@ test.before(async t => {
     AWS.mock( "S3", "getObject", (params, callback) => {
         switch ( params.Key ) {
             case "processed.jpg":
-                callback( null, { Metadata: { "img-processed": "true" }, CacheControl: "cache-control" } );
-                break;
+                return callback( null, { Metadata: { "img-processed": "true" }, CacheControl: "cache-control" } );
             case "empty-file.jpg":
-                callback( null, { ContentLength: 0, Metadata: {}, CacheControl: "cache-control" } );
-                break;
+                return callback( null, { ContentLength: 0, Metadata: {}, CacheControl: "cache-control" } );
             case "network-error.jpg":
-                callback( "Simulated network error" );
-                break;
+                return callback( "Simulated network error" );
             default:
-                callback( null, { Body: fixture, Metadata: {}, CacheControl: "cache-control" } );
+                return callback( null, { Body: fixture, Metadata: {}, CacheControl: "cache-control" } );
         }
     });
     AWS.mock( "S3", "putObject", (params, callback) => {
         switch ( params.Key ) {
             case "network-error.jpg":
-                callback( "Simulated network error" );
-                break;
+                return callback( "Simulated network error" );
             default:
-                callback( null );
+                return callback( null );
         }
     });
 
@@ -85,7 +81,7 @@ test("Push valid ImageData object to S3", async t => {
 
     const response = await fileSystem.putObject(image);
     t.is(response, "S3 putObject success")
-})
+});
 
 test("Fail on network error while pushing ImageData object to S3", async t => {
     const image = new ImageData("network-error.jpg", "fixture", fixture, {}, "private");
@@ -95,4 +91,4 @@ test("Fail on network error while pushing ImageData object to S3", async t => {
     }, (reason) => {
         t.is(reason, "Simulated network error")
     })
-})
+});