Skip to content

Commit 1132f66

Browse files
committed
Set closefd=false for stdio file objects in VM init
- Prevent closing underlying fd when stdio wrappers are dropped - Remove expectedFailure from test_fdopen in test_os.py
1 parent fce2d78 commit 1132f66

2 files changed

Lines changed: 1 addition & 1 deletion

File tree

Lib/test/test_os.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2350,7 +2350,6 @@ def check_bool(self, f, *args, **kwargs):
23502350
with self.assertRaises(RuntimeWarning):
23512351
f(fd, *args, **kwargs)
23522352

2353-
@unittest.expectedFailure # TODO: RUSTPYTHON
23542353
def test_fdopen(self):
23552354
self.check(os.fdopen, encoding="utf-8")
23562355
self.check_bool(os.fdopen, encoding="utf-8")

crates/vm/src/vm/mod.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -328,6 +328,7 @@ impl VirtualMachine {
328328
Some(if write { "wb" } else { "rb" }),
329329
crate::stdlib::io::OpenArgs {
330330
buffering: if unbuffered { 0 } else { -1 },
331+
closefd: false,
331332
..Default::default()
332333
},
333334
self,

0 commit comments

Comments
 (0)