Merge origin/master into yew-docs

Author: Madoshakalaka

.github/workflows/benchmark.yml

@@ -123,7 +123,9 @@ jobs:
 
       - name: Run js-framework-benchmark/webdriver-ts npm run bench
         working-directory: js-framework-benchmark/webdriver-ts
-        run: xvfb-run npm run bench -- --framework keyed/yew keyed/yew-hooks --runner playwright --chromeBinary "${{ steps.setup-chrome.outputs.chrome-path }}"
+        run: xvfb-run npm run bench -- --framework keyed/yew keyed/yew-hooks --runner playwright --chromeBinary "$CHROME_PATH"
+        env:
+          CHROME_PATH: ${{ steps.setup-chrome.outputs.chrome-path }}
 
       - name: Transform results to be fit for display benchmark-action/github-action-benchmark@v1
         run: |

.github/workflows/main-checks.yml

@@ -105,14 +105,14 @@ jobs:
       - name: Run tests - yew
         run: |
           cd packages/yew
-          CHROMEDRIVER=$(which chromedriver) cargo test --features csr,hydration,ssr,test --target wasm32-unknown-unknown
-          GECKODRIVER=$(which geckodriver) cargo test --features csr,hydration,ssr,test --target wasm32-unknown-unknown
+          CHROMEDRIVER="$(which chromedriver)" cargo test --features csr,hydration,ssr,test --target wasm32-unknown-unknown
+          GECKODRIVER="$(which geckodriver)" cargo test --features csr,hydration,ssr,test --target wasm32-unknown-unknown
 
       - name: Run tests - yew-router
         run: |
           cd packages/yew-router
-          CHROMEDRIVER=$(which chromedriver) cargo test --target wasm32-unknown-unknown
-          GECKODRIVER=$(which geckodriver) cargo test --target wasm32-unknown-unknown
+          CHROMEDRIVER="$(which chromedriver)" cargo test --target wasm32-unknown-unknown
+          GECKODRIVER="$(which geckodriver)" cargo test --target wasm32-unknown-unknown
 
   unit_tests:
     name: Unit Tests on ${{ matrix.toolchain }}

.github/workflows/publish-api-docs.yml

@@ -40,8 +40,11 @@ jobs:
             exit 1
           fi
           echo "PR_NUMBER=$pr_number" >> $GITHUB_ENV
-          echo "PR_BRANCH=${{ github.event.workflow_run.head_branch }}" >> $GITHUB_ENV
-          echo "COMMIT_SHA=${{ github.event.workflow_run.head_sha }}" >> $GITHUB_ENV
+          echo "PR_BRANCH=$PR_BRANCH" >> $GITHUB_ENV
+          echo "COMMIT_SHA=$COMMIT_SHA" >> $GITHUB_ENV
+        env:
+          PR_BRANCH: ${{ github.event.workflow_run.head_branch }}
+          COMMIT_SHA: ${{ github.event.workflow_run.head_sha }}
 
       - if: github.event.workflow_run.event == 'push'
         name: Apply push environment
@@ -59,5 +62,5 @@ jobs:
           commentURLPath: "/next/yew"
           # PR information
           prNumber: "${{ env.PR_NUMBER }}"
-          prBranchName: "${{ env.PR_BRANCH }}"
+          prBranchName: ${{ env.PR_BRANCH }}
           commitSHA: "${{ env.COMMIT_SHA }}"

.github/workflows/publish-website.yml

@@ -40,8 +40,11 @@ jobs:
             exit 1
           fi
           echo "PR_NUMBER=$pr_number" >> $GITHUB_ENV
-          echo "PR_BRANCH=${{ github.event.workflow_run.head_branch }}" >> $GITHUB_ENV
-          echo "COMMIT_SHA=${{ github.event.workflow_run.head_sha }}" >> $GITHUB_ENV
+          echo "PR_BRANCH=$PR_BRANCH" >> $GITHUB_ENV
+          echo "COMMIT_SHA=$COMMIT_SHA" >> $GITHUB_ENV
+        env:
+          PR_BRANCH: ${{ github.event.workflow_run.head_branch }}
+          COMMIT_SHA: ${{ github.event.workflow_run.head_sha }}
 
       - if: github.event.workflow_run.event == 'push'
         name: Apply push environment
@@ -59,5 +62,5 @@ jobs:
           commentURLPath: "/docs/next"
           # PR information
           prNumber: "${{ env.PR_NUMBER }}"
-          prBranchName: "${{ env.PR_BRANCH }}"
+          prBranchName: ${{ env.PR_BRANCH }}
           commitSHA: "${{ env.COMMIT_SHA }}"

.github/workflows/publish.yml

@@ -47,26 +47,25 @@ jobs:
           version: =1.1.1
 
       - name: Cargo login
-        run: cargo login ${{ secrets.CRATES_IO_TOKEN }}
+        run: echo ${{ secrets.CRATES_IO_TOKEN }} | cargo login
 
-      - name: Build command
+      - name: Release yew
         shell: bash
         env:
           PACKAGES: ${{ github.event.inputs.packages }}
+          LEVEL: ${{ github.event.inputs.level }}
         run: |
-          output=""
-          for pkg in ${{ github.event.inputs.packages }}
-          do
-            output+="--package $pkg " 
+          arguments=()
+          for pkg in $PACKAGES; do
+            arguments+=("--package" "$pkg")
           done
-          echo "pkg=$output" >> $GITHUB_ENV
-
-      - name: Release yew
-        run: cargo release ${{ github.event.inputs.level }} --execute --no-confirm ${{ env.pkg }}
+          cargo release "$LEVEL" --execute --no-confirm "${arguments[@]}"
 
       - name: Collect release info
         id: releaseinfo
-        run: cargo run -p collect-release-info -- ${{ github.event.inputs.packages }}
+        env:
+          PACKAGES: ${{ github.event.inputs.packages }}
+        run: cargo run -p collect-release-info -- $PACKAGES
 
       - name: Create a version branch
         if: github.event.inputs.level != 'patch'