Add benchmark validation script; tighten Ray worker env and add graceful shutdown#3
Open
ydjplus wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
benchmark_validate.pywhich implements a validation-only flow usingRayPPOTrainer, an on-deviceRewardManager,LLMGenerationManagersupport for search/non-search modes, progress logging withtqdm, and per-datasource metric aggregation._RAY_WORKER_ENV_VARSdict and use it inmain_ppo.pyandmain_ppo_format.pyto setray.init(runtime_env={'env_vars': ...})and replace the inline env dict.trainer.fit()inmain_ppo.pyandmain_ppo_format.pywithtry/finallyto calltrainer.shutdown()on exit.verl/trainer/ppo/ray_trainer.pyaddimport logging, an_is_shutdownflag, and ashutdown()method that attempts toray.kill()worker actors and remove Ray placement groups viaremove_placement_groupto free resources.Testing
Codex Task