Resolve GET parameters in URL, restoring BC

See PR #20

Author: thekid

src/main/php/webservices/rest/RestClient.class.php

@@ -213,7 +213,7 @@ public function execute(RestRequest $request) {
     } else if ($request->hasBody()) {
       $send->setParameters($request->getBody());
     } else {
-      $send->setParameters($request->getParameters());
+      $send->setParameters($request->targetParameters());
     }
 
     try {

src/main/php/webservices/rest/RestRequest.class.php

@@ -451,6 +451,15 @@ private function authenticate($base, $url) {
     return $url;
   }
 
+  /**
+   * Returns parameters, resolving segments if necessary
+   *
+   * @return [:string]
+   */
+  public function targetParameters() {
+    return array_map([$this, 'resolve'], $this->parameters);
+  }
+
   /**
    * Resolves target URL
    *
@@ -475,7 +484,7 @@ public function targetUrl(URL $base= null) {
       $url= clone $base;
     }
 
-    return $url->setParams(array_map([$this, 'resolve'], $this->parameters))->setPath($this->resolve($resource));
+    return $url->setParams($this->targetParameters())->setPath($this->resolve($resource));
   }
 
   /**

src/test/php/webservices/rest/unittest/RestRequestTest.class.php

@@ -320,6 +320,20 @@ public function targetWithSegmentParametersAndConstantsMixed() {
     $this->assertEquals('/repos/thekid/xp-framework/issues/1', $fixture->targetUrl(new URL('http://test'))->getPath());
   }
 
+  #[@test]
+  public function segments_allowed_in_get_parameters() {
+    $fixture= new RestRequest('/repos/?user={user}');
+    $fixture->addSegment('user', 'thekid');
+    $this->assertEquals(['user' => 'thekid'], $fixture->targetUrl(new URL('http://test'))->getParams());
+  }
+
+  #[@test]
+  public function segments_in_parameters_resolved_in_target_parameters() {
+    $fixture= new RestRequest('/repos/?user={user}');
+    $fixture->addSegment('user', 'thekid');
+    $this->assertEquals(['user' => 'thekid'], $fixture->targetParameters());
+  }
+
   #[@test, @values(['/rest/api/v2/', '/rest/api/v2'])]
   public function relativeResource($base) {
     $fixture= new RestRequest('issues');