Two things I think you need to add into logs.
-
if turn in flight flag is true, logs are supposed to record this, since it's valuable for debugging, especially when debug mode on (if codeg has)
|
if s.turn_in_flight { |
|
return Err(AcpError::TurnInProgress); |
|
} |
-
read updates until turn complete.
|
loop { |
|
tokio::select! { |
|
update = session.read_update() => { |
|
let update = match update { |
|
Ok(u) => u, |
|
Err(e) => { |
|
// Silent-drop site #1 (transport/decode). |
|
// Record it: an agent whose output we |
|
// couldn't decode looks identical to one |
|
// that said nothing, and the two need |
|
// completely different fixes. |
|
probe.note_dropped(DropSite::Decode, &e); |
|
tracing::warn!("[ACP] Ignoring unrecognized session update: {e}"); |
|
continue; |
|
} |
|
}; |
|
match update { |
while reading updates, there is a fallback if any condition doesn't match. but it failed to tell user what's going on. and then logs didn't reveal anything. i think this should be recored.
for example, if user send another msg while turn didn't finish , log should record this behavior at least.
code might be:
Some(ConnectionCommand::Prompt { .. }) => {
tracing::warn!("[ACP] in-turn Prompt DROPPED (a turn is still running)");
}
what's your opinion? if this two problems is meaningful , i'd like to PR.
Two things I think you need to add into logs.
if
turn in flightflag is true, logs are supposed to record this, since it's valuable for debugging, especially when debug mode on (if codeg has)codeg/src-tauri/src/acp/manager.rs
Lines 732 to 734 in 5dafe50
read updates until turn complete.
codeg/src-tauri/src/acp/connection.rs
Lines 6238 to 6254 in 5dafe50
while reading updates, there is a fallback if any condition doesn't match. but it failed to tell user what's going on. and then logs didn't reveal anything. i think this should be recored.
codeg/src-tauri/src/acp/connection.rs
Line 6386 in 5dafe50
for example, if user send another msg while turn didn't finish , log should record this behavior at least.
code might be:
what's your opinion? if this two problems is meaningful , i'd like to PR.