Skip to content

Commit fa51de9

Browse files
auto-submit[bot]auto-submit[bot]
andauthored
Reverts "[cupertino.dart] Implement CupertinoMenuAnchor and CupertinoMenuItem using RawMenuAnchor (flutter#174695)" (flutter#182010)
<!-- start_original_pr_link --> Reverts: flutter#174695 <!-- end_original_pr_link --> <!-- start_initiating_author --> Initiated by: jtmcdole <!-- end_initiating_author --> <!-- start_revert_reason --> Reason for reverting: post submits are broken Please do not directly add to the merge queue until all presubmits pass. flutter-tizen#21 main.<anonymous closure> (file:///C:/b/s/w/ir/x/w/flutter/packages/flutter/test/cupertino/menu_anchor_test.dart:969:18) <!-- end_revert_reason --> <!-- start_original_pr_author --> Original PR Author: davidhicks980 <!-- end_original_pr_author --> <!-- start_reviewers --> Reviewed By: {dkwingsmt} <!-- end_reviewers --> <!-- start_revert_body --> This change reverts the following previous change: This PR implements `CupertinoMenuAnchor`, `CupertinoMenuItem`, and `CupertinoMenuDivider` using `RawMenuAnchor`. Resolves flutter#60298, notDmDrl/pull_down_button#26, flutter#137936. https://github.com/user-attachments/assets/551f2169-cac4-4078-890b-6728ab9c2ae5 Dartpad: https://dartpad.dev/8c6bba779b6a00e95582b61b132292bc @dkwingsmt ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md <!-- end_revert_body --> Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
1 parent a12bfe6 commit fa51de9

8 files changed

Lines changed: 2 additions & 10177 deletions

File tree

examples/api/lib/cupertino/menu_anchor/menu_anchor.0.dart

Lines changed: 0 additions & 86 deletions
This file was deleted.

examples/api/lib/cupertino/menu_anchor/menu_anchor.1.dart

Lines changed: 0 additions & 133 deletions
This file was deleted.

examples/api/test/cupertino/menu_anchor/menu_anchor.0_test.dart

Lines changed: 0 additions & 49 deletions
This file was deleted.

examples/api/test/cupertino/menu_anchor/menu_anchor.1_test.dart

Lines changed: 0 additions & 82 deletions
This file was deleted.

packages/flutter/lib/cupertino.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ export 'src/cupertino/list_section.dart';
4949
export 'src/cupertino/list_tile.dart';
5050
export 'src/cupertino/localizations.dart';
5151
export 'src/cupertino/magnifier.dart';
52-
export 'src/cupertino/menu_anchor.dart';
5352
export 'src/cupertino/nav_bar.dart';
5453
export 'src/cupertino/page_scaffold.dart';
5554
export 'src/cupertino/picker.dart';

0 commit comments

Comments
 (0)