[Crash] Geoscape crash with X-Com Files 3.9.1b

[TheYellowArchitect]

Playing X-Com Files, I encountered a crash in the very early game. It is replicatable. Both of us were playing XCOM side. The battle ended by a taser pistol on XCOM Side -> End Turn -> I guess the enemy bled out as the battle ended his turn without XCOM operatives losing. It didn't happen exactly after the battle, but when the vehicle is returning to base (public car, 1 passenger)

The connection was TCP Private, and LAN. We both were using Linux's AppImage, version 1.8.4
Both of us had UFO and TFTD folder.

Where are the logs or something so I send for you to confirm?
There was no obvious output (e.g. "Error") on the last lines from the terminal. We were both playing on Linux.
I also have the save files: return-base-crash.zip though these files are only by P1 (host)
I managed to load one of these files and replicate the crash in a singleplayer game!
Load the file 'coop_mission' and just fast-forward -> crash
I am pretty sure the autosaved file of geoscape crashed too in multiplayer but it doesn't in singleplayer.

Aside of that, Geoscape was synced well. And when in a different save file (P2 playing as Alien) there were no desyncs.

I don't know if it's related, but I had enabled Cyrillic Names sub-mod of X-Com Files (it's by default included) and XFilesResound

[xcomcoopdev]

Hi,

I tested with these mods:

• x-com-files ver: 3.9.1
• XCF-CyrNames ver: Camio, 20.07.2022, fix 1
• dark-geoscape ver: 1.0
• x-com-resound ver: 2.91

Thank you for the save files. They were enough for me to find the cause of the problem, so there is no need to send any more logs.

When I loaded the "coop_mission" save in both single-player and multiplayer, the game crashed whenever I fast-forwarded time or entered a base.

I found corrupted data in the "transfers" section of that save file. One transfer had a duration of five hours, but it did not contain any data. This caused the game to crash.

I am pretty sure this also caused the crash at the end of the Battlescape mission, because the game checks base storage when a mission ends.

Next, I will fix transfer synchronization to prevent invalid transfer data from being saved. If a transfer fails, the game should notify the player and cancel the transfer.

If you want, it could be helpful to check which item was being transferred when the save became corrupted.

Here is the fixed save: coop_mission_fixed.zip

[TheYellowArchitect]

Next, I will fix transfer synchronization to prevent invalid transfer data from being saved. If a transfer fails, the game should notify the player and cancel the transfer.

I thank you for looking into this bug, as it makes me happy to know such a hype mod is being worked on! 😁

I asked my friend if he remembers what he did, and whether he transferred anything. A week has passed since this save file so he doesn't remember; but says maybe it's possible he transferred some item, and also, he clicked my base and tried to sell/sack my items or purchase items for me (that's his claim, but it's been a week)

I also appreciate the fixed save, but given the 2nd base being deleted bug, and me binging X-Com Files mod in singleplayer with Brutal AI (and already feel the long-war-tier grinding) I won't play XCOM for a year after I finish the campaign (if I finish it)

That said, if you want me to do any testing, e.g. for a PR or a bugfix, I am available.