Tests: Improve Windows compatibility (#382)

Author: swissspidy

features/install-wp-tests.feature

@@ -1,6 +1,8 @@
 # Note: You need to execute the mysql command `GRANT ALL PRIVILEGES ON wp_cli_test_scaffold.* TO "wp_cli_test"@"localhost" IDENTIFIED BY "{DB_PASSWORD}";` for these tests to work locally.
 Feature: Scaffold install-wp-tests.sh tests
 
+  # TODO: Fix this on Windows. Fails because /usr/bin/env bash is not available.
+  @skip-windows
   Scenario: Help should be displayed
     Given a WP install
     And I run `wp plugin path`

features/scaffold-plugin-tests.feature

@@ -1,5 +1,7 @@
 Feature: Scaffold plugin unit tests
 
+  # TODO: Fix this on Windows. Fails because is_executable() fails for .sh files.
+  @skip-windows
   Scenario: Scaffold plugin tests
     Given a WP install
     When I run `wp plugin path`
@@ -220,10 +222,7 @@ Feature: Scaffold plugin unit tests
     Then the {RUN_DIR}/wp-content/plugins/foo.php file should exist
 
     When I try `wp scaffold plugin-tests foo`
-    Then STDERR should be:
-      """
-      Error: Invalid plugin slug specified. No such target directory '{RUN_DIR}/wp-content/plugins/foo'.
-      """
+    Then STDERR should match #Error: Invalid plugin slug specified\. No such target directory '.*wp-content/plugins/foo'\.#
     And the return code should be 1
 
     When I try `wp scaffold plugin-tests .`
@@ -271,10 +270,7 @@ Feature: Scaffold plugin unit tests
     When I run `rm -rf {PLUGIN_DIR} && touch {PLUGIN_DIR}`
     Then the return code should be 0
     When I try `wp scaffold plugin-tests hello-world`
-    Then STDERR should be:
-      """
-      Error: Invalid plugin slug specified. No such target directory '{PLUGIN_DIR}'.
-      """
+    Then STDERR should match #Error: Invalid plugin slug specified\. No such target directory '.*hello-world'\.#
     And the return code should be 1
 
   Scenario: Scaffold plugin tests with a symbolic link

features/scaffold-theme-tests.feature

@@ -256,6 +256,8 @@ Feature: Scaffold theme unit tests
     When I run `rm -f {THEME_DIR}/twentytwelve && mv -f {THEME_DIR}/hide-twentytwelve {THEME_DIR}/twentytwelve`
     Then the return code should be 0
 
+  # TODO: Fix this on Windows. Fails because unlink fails on directories.
+  @skip-windows
   Scenario: Scaffold theme tests with a symbolic link
     # Temporarily move the whole theme dir and create a symbolic link to it.
     When I run `mv -f {THEME_DIR} {RUN_DIR}/alt-themes && ln -s {RUN_DIR}/alt-themes {THEME_DIR}`

src/Scaffold_Command.php

@@ -1008,6 +1008,8 @@ protected function create_files( $files_and_contents, $force ) {
 				continue;
 			}
 
+			$contents = str_replace( "\r\n", "\n", $contents );
+
 			$wp_filesystem->mkdir( dirname( $filename ) );
 
 			// Create multi-level folders.