-
Notifications
You must be signed in to change notification settings - Fork 40
Open
Labels
command:media-fix-orientationRelated to 'media fix-orientation' commandRelated to 'media fix-orientation' commandscope:testingRelated to testingRelated to testingstate:unconfirmed
Description
The two tests for wp media fix-orientation are currently disabled because they only run on WP < 4.9 but we require 4.9+:
media-command/features/media-fix-orientation.feature
Lines 14 to 131 in c9ac129
| # On WP 4.9 tests this results in "Couldn't fix orientation". | |
| # Todo: Revisit this test and improve or potentially remove it if useless. | |
| @require-extension-exif @require-wp-4.0 @less-than-wp-4.9 | |
| Scenario: Fix orientation for all images | |
| Given download: | |
| | path | url | | |
| | {CACHE_DIR}/landscape-2.jpg | https://raw.githubusercontent.com/thrijith/test-images/master/Landscape_2.jpg | | |
| | {CACHE_DIR}/landscape-5.jpg | https://raw.githubusercontent.com/thrijith/test-images/master/Landscape_5.jpg | | |
| | {CACHE_DIR}/portrait-4.jpg | https://raw.githubusercontent.com/thrijith/test-images/master/Portrait_4.jpg | | |
| | {CACHE_DIR}/portrait-6.jpg | https://raw.githubusercontent.com/thrijith/test-images/master/Portrait_6.jpg | | |
| And I run `wp option update uploads_use_yearmonth_folders 0` | |
| When I run `wp media import {CACHE_DIR}/landscape-2.jpg --title="Landscape Two" --porcelain` | |
| Then save STDOUT as {LANDSCAPE_TWO} | |
| When I run `wp media import {CACHE_DIR}/landscape-5.jpg --title="Landscape Five" --porcelain` | |
| Then save STDOUT as {LANDSCAPE_FIVE} | |
| When I run `wp media import {CACHE_DIR}/portrait-4.jpg --title="Portrait Four" --porcelain` | |
| Then save STDOUT as {PORTRAIT_FOUR} | |
| When I run `wp media fix-orientation --dry-run` | |
| Then STDOUT should contain: | |
| """ | |
| 3 "Portrait Four" (ID {PORTRAIT_FOUR}) will be affected. | |
| """ | |
| And STDOUT should contain: | |
| """ | |
| 3 "Landscape Five" (ID {LANDSCAPE_FIVE}) will be affected. | |
| """ | |
| And STDOUT should contain: | |
| """ | |
| 3 "Landscape Two" (ID {LANDSCAPE_TWO}) will be affected. | |
| """ | |
| And STDOUT should contain: | |
| """ | |
| Success: 3 of 3 images will be affected. | |
| """ | |
| When I run `wp media fix-orientation` | |
| Then STDOUT should contain: | |
| """ | |
| 3 Fixing orientation for "Portrait Four" (ID {PORTRAIT_FOUR}). | |
| """ | |
| And STDOUT should contain: | |
| """ | |
| 3 Fixing orientation for "Landscape Five" (ID {LANDSCAPE_FIVE}). | |
| """ | |
| And STDOUT should contain: | |
| """ | |
| 3 Fixing orientation for "Landscape Two" (ID {LANDSCAPE_TWO}). | |
| """ | |
| And STDOUT should contain: | |
| """ | |
| Success: Fixed 3 of 3 images. | |
| """ | |
| # Verify orientation fix. | |
| When I run `wp media fix-orientation` | |
| Then STDOUT should contain: | |
| """ | |
| 3 No orientation fix required for "Portrait Four" (ID {PORTRAIT_FOUR}). | |
| """ | |
| And STDOUT should contain: | |
| """ | |
| 3 No orientation fix required for "Landscape Five" (ID {LANDSCAPE_FIVE}). | |
| """ | |
| And STDOUT should contain: | |
| """ | |
| 3 No orientation fix required for "Landscape Two" (ID {LANDSCAPE_TWO}). | |
| """ | |
| And STDOUT should contain: | |
| """ | |
| Success: Images already fixed. | |
| """ | |
| # On newer versions (5.3+) the image is already considered fixed. | |
| # On WP 4.9 tests this results in "Couldn't fix orientation". | |
| # Todo: Revisit this test and improve or potentially remove it if useless. | |
| @require-extension-exif @require-wp-4.0 @less-than-wp-4.9 | |
| Scenario: Fix orientation for single image | |
| Given download: | |
| | path | url | | |
| | {CACHE_DIR}/portrait-6.jpg | https://raw.githubusercontent.com/thrijith/test-images/master/Portrait_6.jpg | | |
| When I run `wp media import {CACHE_DIR}/portrait-6.jpg --title="Portrait Six" --porcelain` | |
| Then save STDOUT as {PORTRAIT_SIX} | |
| When I run `wp media fix-orientation {PORTRAIT_SIX}` | |
| Then STDOUT should be: | |
| """ | |
| 1/1 Fixing orientation for "Portrait Six" (ID {PORTRAIT_SIX}). | |
| Success: Fixed 1 of 1 images. | |
| """ | |
| # Verify orientation fix. | |
| When I run `wp media fix-orientation {PORTRAIT_SIX}` | |
| Then STDOUT should be: | |
| """ | |
| 1/1 No orientation fix required for "Portrait Six" (ID {PORTRAIT_SIX}). | |
| Success: Image already fixed. | |
| """ | |
| @require-wp-4.0 | |
| Scenario: Fix orientation for non existent image | |
| When I try `wp media fix-orientation 9999` | |
| Then STDERR should be: | |
| """ | |
| Error: No images found. | |
| """ |
Do we need new tests for 4.9+ or did this command become obsolete and should be deprecated instead?
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
command:media-fix-orientationRelated to 'media fix-orientation' commandRelated to 'media fix-orientation' commandscope:testingRelated to testingRelated to testingstate:unconfirmed