Skip to content

Commit bad34a4

Browse files
authored
Merge pull request ipaddress-gem#28 from Adam21e/remove_dup_from_summarize
Remove dup from ipv6 summarize to give small performance boost
2 parents 904e1ac + 68a4037 commit bad34a4

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

lib/ipaddress_2/ipv6.rb

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -989,17 +989,18 @@ def self.parse_hex(hex, prefix=128)
989989
def self.summarize(*args)
990990
# one network? no need to summarize
991991
return [args.first.network] if args.size == 1
992+
args_size = args.size
992993

993994
i = 0
994-
result = args.dup.sort.map{|ip| ip.network}
995+
result = args.sort.map{|ip| ip.network}
995996
while i < result.size-1
996997
sum = result[i] + result[i+1]
997998
result[i..i+1] = sum.first if sum.size == 1
998999
i += 1
9991000
end
10001001

10011002
result.flatten!
1002-
if result.size == args.size
1003+
if result.size == args_size
10031004
# nothing more to summarize
10041005
return result
10051006
else

0 commit comments

Comments
 (0)