Skip to content

Commit e802679

Browse files
committed
Since memsize argument document says MB (and not MiB), I changed
the "* 1024 * 1024" to "* 1000 * 1000". The alternative was to document "MiB", but as far as I can tell none of the above layers use 1024. This said, _every time_ we've used any unit other than just byte, we've had errors. Perhaps we should change it all to "memory size in bytes" and that's it.
1 parent ffac645 commit e802679

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

bin/wfbench

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ def io_write_benchmark_user_input_data_size(outputs,
252252
def io_alternate(inputs, outputs, cpu_queue: multiprocessing.Queue, memory_limit=None, rundir=None, event=None):
253253
"""Alternate between reading and writing to a file, ensuring read only happens after write."""
254254

255-
if memory_limit is None:
255+
if memory_limit is None:f
256256
memory_limit = 10 * 1024 * 1024 # sys.maxsize
257257
memory_limit = int(memory_limit)
258258

@@ -397,7 +397,7 @@ def main():
397397

398398
log_info(f"Starting {args.name} Benchmark")
399399

400-
mem_bytes = args.mem * 1024 * 1024 if args.mem else None
400+
mem_bytes = args.mem * 1000 * 1000 if args.mem else None
401401

402402
procs = []
403403
io_proc = None

0 commit comments

Comments
 (0)