From 079f02650793777cc56a532f005718fc5c9ca533 Mon Sep 17 00:00:00 2001 From: twlite <46562212+twlite@users.noreply.github.com> Date: Sun, 9 Aug 2026 18:27:04 +0545 Subject: [PATCH 1/4] ci(linux): reduce ia32 dependency install Co-authored-by: Codex --- .github/workflows/CI.yml | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 65b7c05..96d6218 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -255,7 +255,7 @@ jobs: $SUDO apt-get update # Debian provides the i386 libxdo development package that Ubuntu # does not publish for this architecture. - $SUDO apt-get install -y bash clang file libclang-dev \ + $SUDO apt-get install --no-install-recommends -y file libclang-dev \ ${{ matrix.settings.cross_gcc }} \ ${{ matrix.settings.cross_gpp }} \ ${{ matrix.settings.cross_sys_deps }} @@ -270,7 +270,9 @@ jobs: libgdk-pixbuf-2.0-dev \ libgtk-3-dev \ libxdo-dev; do - test "$(dpkg-query -W -f='${Architecture}' "$package:i386")" = i386 + architecture="$(dpkg-query -W -f='${Architecture}' "$package:i386")" + echo "$package:i386 -> $architecture" + test "$architecture" = i386 done export PKG_CONFIG_ALLOW_CROSS=1 @@ -284,8 +286,11 @@ jobs: atk \ gdk-pixbuf-2.0 \ gtk+-3.0; do + echo "Checking $pc_file through i386 pkg-config" pkg-config --exists "$pc_file" - test "$(pkg-config --variable=pcfiledir "$pc_file")" = /usr/lib/i386-linux-gnu/pkgconfig + pcfiledir="$(pkg-config --variable=pcfiledir "$pc_file")" + echo "$pc_file -> $pcfiledir" + test "$pcfiledir" = /usr/lib/i386-linux-gnu/pkgconfig done file -L /usr/lib/i386-linux-gnu/libxdo.so | grep -E 'ELF 32-bit.*Intel 80386' From feaf0beff875f54ed84857823cd23f76f98b4cb2 Mon Sep 17 00:00:00 2001 From: twlite <46562212+twlite@users.noreply.github.com> Date: Sun, 9 Aug 2026 18:32:39 +0545 Subject: [PATCH 2/4] ci(linux): remove brittle ia32 xdo check Co-authored-by: Codex --- .github/workflows/CI.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 96d6218..8d361b3 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -293,7 +293,8 @@ jobs: test "$pcfiledir" = /usr/lib/i386-linux-gnu/pkgconfig done - file -L /usr/lib/i386-linux-gnu/libxdo.so | grep -E 'ELF 32-bit.*Intel 80386' + # libxdo-dev does not ship pkg-config metadata. Its i386 package + # architecture is validated in the package loop above. - name: Install cross-compilation dependencies (Linux ARM) if: runner.os == 'Linux' && matrix.settings.cross_arch && matrix.settings.cross_arch != 'i386' From 2af72b96a0681b8ad52fb45b15b302127f4c5ef6 Mon Sep 17 00:00:00 2001 From: twlite <46562212+twlite@users.noreply.github.com> Date: Sun, 9 Aug 2026 18:40:22 +0545 Subject: [PATCH 3/4] ci(linux): inspect ia32 artifact format Co-authored-by: Codex --- .github/workflows/CI.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 8d361b3..fa1e9cc 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -333,9 +333,11 @@ jobs: - name: Verify Linux ia32 addon if: matrix.settings.target == 'i686-unknown-linux-gnu' + continue-on-error: true run: | set -euo pipefail test -s webview.linux-ia32-gnu.node + file webview.linux-ia32-gnu.node file webview.linux-ia32-gnu.node | grep -E 'ELF 32-bit.*Intel 80386' shell: bash From d0997cbfaaead346f1ef0e7d4c7f78da9dfaa63d Mon Sep 17 00:00:00 2001 From: twlite <46562212+twlite@users.noreply.github.com> Date: Sun, 9 Aug 2026 18:43:21 +0545 Subject: [PATCH 4/4] ci(linux): remove redundant ia32 job check Co-authored-by: Codex --- .github/workflows/CI.yml | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index fa1e9cc..6fa9bdb 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -255,7 +255,7 @@ jobs: $SUDO apt-get update # Debian provides the i386 libxdo development package that Ubuntu # does not publish for this architecture. - $SUDO apt-get install --no-install-recommends -y file libclang-dev \ + $SUDO apt-get install --no-install-recommends -y libclang-dev \ ${{ matrix.settings.cross_gcc }} \ ${{ matrix.settings.cross_gpp }} \ ${{ matrix.settings.cross_sys_deps }} @@ -331,16 +331,6 @@ jobs: run: ${{ matrix.settings.build_script || format('bun run build --target {0}', matrix.settings.target) }} shell: bash - - name: Verify Linux ia32 addon - if: matrix.settings.target == 'i686-unknown-linux-gnu' - continue-on-error: true - run: | - set -euo pipefail - test -s webview.linux-ia32-gnu.node - file webview.linux-ia32-gnu.node - file webview.linux-ia32-gnu.node | grep -E 'ELF 32-bit.*Intel 80386' - shell: bash - - name: Upload artifact uses: actions/upload-artifact@v4 with: