Commit 501a140
authored
Remove superfluous case normalization logic in App/User (#1049)
The Laravel email column is a `varchar(255)` with a `utf8mb4_unicode_ci` collation[1] which is case-insensitive. No further case normalization is required, and doing so will slow down the search.
Also, `strtolower()` only converts ASCII alphabetic characters[2]. `mb_strtolower()` is required to convert non-ASCII character as well.
[1]: https://mariadb.com/docs/server/reference/data-types/string-data-types/character-sets/supported-character-sets-and-collations
[2]: https://www.php.net/manual/en/function.strtolower.php
Bug: T4156401 parent 85b46f9 commit 501a140
3 files changed
Lines changed: 2 additions & 6 deletions
File tree
- app
- Console/Commands/User
- tests/Commands/User
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
| 19 | + | |
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
121 | 121 | | |
122 | 122 | | |
123 | 123 | | |
124 | | - | |
125 | | - | |
126 | | - | |
127 | | - | |
128 | 124 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
60 | 60 | | |
61 | 61 | | |
62 | 62 | | |
63 | | - | |
| 63 | + | |
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
| |||
0 commit comments