XBPS_CHECK_PKGS is a global "do we test packages" check, set with the -Q option or in etc/conf.
During cross builds this variable is still set true despite checkdepends not being installed and do_check not being used.
A lot of templates just check [ "$XBPS_CHECK_PKGS" ] which works in most cases, but not in cases where its used to explicitly disable tests because the build system might depend on something in checkdepends if tests are enabled:
if [ -z "$XBPS_CHECK_PKGS" ]; then
configure_args+=" -Dtests=false"
fixbps-src itself usually does a check like [ "$XBPS_CHECK_PKGS" ] && [ -z "$XBPS_CROSS_BUILD" ].
I think we should either change XBPS_CHECK_PKGS to indicate whether checks are going to be run or add a new variable for that.
XBPS_CHECK_PKGSis a global "do we test packages" check, set with the-Qoption or inetc/conf.During cross builds this variable is still set true despite
checkdependsnot being installed anddo_checknot being used.A lot of templates just check
[ "$XBPS_CHECK_PKGS" ]which works in most cases, but not in cases where its used to explicitly disable tests because the build system might depend on something incheckdependsif tests are enabled:xbps-srcitself usually does a check like[ "$XBPS_CHECK_PKGS" ] && [ -z "$XBPS_CROSS_BUILD" ].I think we should either change
XBPS_CHECK_PKGSto indicate whether checks are going to be run or add a new variable for that.