Skip to content

Commit 6d01417

Browse files
v1.34.49: passwordless minisign CI key + secure gitignore (#308)
1 parent 3dd7b6b commit 6d01417

3 files changed

Lines changed: 8 additions & 6 deletions

File tree

.github/workflows/release.yml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -460,7 +460,6 @@ jobs:
460460
shell: bash
461461
env:
462462
MINISIGN_PRIVATE_KEY_B64: ${{ secrets.MINISIGN_PRIVATE_KEY_B64 }}
463-
MINISIGN_PASSWORD: ${{ secrets.MINISIGN_PASSWORD }}
464463
run: |
465464
set -euxo pipefail
466465
cd dist
@@ -479,13 +478,9 @@ jobs:
479478
printf "%s" "$MINISIGN_PRIVATE_KEY_B64" | base64 -d > "$keyfile"
480479
test -s "$keyfile"
481480
482-
# clé minisign chiffrée -> password obligatoire
483-
test -n "${MINISIGN_PASSWORD:-}" || { echo "MINISIGN_PASSWORD missing" >&2; exit 1; }
484-
485481
for f in vix-*.tar.gz vix-*.zip; do
486482
[ -f "$f" ] || continue
487-
# IMPORTANT: pas de -x (c'est le chemin du .minisig), et on envoie un vrai newline
488-
printf '%s\n' "$MINISIGN_PASSWORD" | "$MS" -S -s "$keyfile" -m "$f"
483+
"$MS" -S -s "$keyfile" -m "$f"
489484
done
490485
491486
rm -f "$keyfile"

.gitignore

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,3 +77,8 @@ create-labels.sh
7777
*.key
7878
*.minisig
7979
*.sha256
80+
# minisign private keys (CI)
81+
*.key
82+
*.key.b64
83+
minisign_ci.key
84+
minisign_ci.key.b64

minisign_ci.pub

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
untrusted comment: minisign public key 3BD72CED2937E88
2+
RWSIfpPSznK9A1gWUc8Eg2iXXQwU5d9BYuQNKGOcoujAF2stPu5rKFjQ

0 commit comments

Comments
 (0)