There are a lot of magic numbers inside of SWT in HiDPI related variables used for calculating sizes, offsets, etc. The assumption is that all of them should be scaled up/down via DPIUtil when they are used. Nevertheless, for each variable we need to test for a visible effect, before changing it.
How to test/adapt
- Compare the effect of changing a magic number. Good workflow should be:
- Start it without the changes on a high zoom, e.g. 200
- Start it with the changes on a low zoom, e.g. 200, move it to 200
- Compare both application
- Fix one effect per PR. If e.g. the size calculation in a class is affected by one or more variables, adjust only them and don't adjust other places in the same class
- Create screenshots to show differences before and after the change## Current work
There is already an (old) branch with some of the magic numbers partially adjusted: https://github.com/akoch-yatta/eclipse.platform.swt/tree/scale-up-magic-numbers
There are a lot of magic numbers inside of SWT in HiDPI related variables used for calculating sizes, offsets, etc. The assumption is that all of them should be scaled up/down via DPIUtil when they are used. Nevertheless, for each variable we need to test for a visible effect, before changing it.
How to test/adapt
There is already an (old) branch with some of the magic numbers partially adjusted: https://github.com/akoch-yatta/eclipse.platform.swt/tree/scale-up-magic-numbers