Introduce PropifyException and ReflectionUtils for improved error handling and reflection

y1j2x34 · y1j2x34 · commit c5a38ddaa085 · 2025-05-01T20:47:00.000+08:00
diff --git a/propify/src/main/java/com/vgerbot/propify/PropifyProcessor.java b/propify/src/main/java/com/vgerbot/propify/PropifyProcessor.java
@@ -9,6 +9,7 @@
 import com.vgerbot.propify.loader.CompileTimeResourceLoaderProvider;
 import com.vgerbot.propify.logger.CompileTimeLogger;
 import org.apache.commons.configuration2.Configuration;
+import com.vgerbot.propify.common.PropifyException;
 
 import javax.annotation.processing.*;
 import javax.lang.model.SourceVersion;
@@ -138,7 +139,7 @@ public boolean process(final Set<? extends TypeElement> annotations, final Round
                                     "Failed to process annotation: " + message, element);
                         }
                     } else {
-                        throw new RuntimeException(e);
+                        throw new PropifyException("Failed to process annotation", e);
                     }
                 }
             }
diff --git a/propify/src/main/java/com/vgerbot/propify/common/FlatDottedMapConfiguration.java b/propify/src/main/java/com/vgerbot/propify/common/FlatDottedMapConfiguration.java
@@ -11,6 +11,8 @@
 import org.apache.commons.configuration2.tree.DefaultExpressionEngine;
 import org.apache.commons.configuration2.tree.DefaultExpressionEngineSymbols;
 
+import com.vgerbot.propify.common.ReflectionUtils;
+
 /**
  * A configuration class that extends MapConfiguration to provide support for accessing
  * nested properties using dot notation and array/list indexing.
@@ -212,8 +214,7 @@ private Object getNestedProperty(Object container, String propertyKey) {
             return ((Map<?, ?>) container).get(propertyKey);
         } else {
             try {
-                Field field = container.getClass().getDeclaredField(propertyKey);
-                field.setAccessible(true);
+                Field field = ReflectionUtils.getDeclaredField(container.getClass(), propertyKey);
                 return field.get(container);
             } catch (Exception e) {
                 return null;
diff --git a/propify/src/main/java/com/vgerbot/propify/common/PropifyException.java b/propify/src/main/java/com/vgerbot/propify/common/PropifyException.java
@@ -0,0 +1,11 @@
+package com.vgerbot.propify.common;
+
+public class PropifyException extends RuntimeException {
+    public PropifyException(String message) {
+        super(message);
+    }
+
+    public PropifyException(String message, Throwable cause) {
+        super(message, cause);
+    }
+} 
diff --git a/propify/src/main/java/com/vgerbot/propify/common/ReflectionUtils.java b/propify/src/main/java/com/vgerbot/propify/common/ReflectionUtils.java
@@ -0,0 +1,48 @@
+package com.vgerbot.propify.common;
+
+import java.lang.reflect.AccessibleObject;
+import java.lang.reflect.Field;
+import java.lang.reflect.Method;
+import java.lang.reflect.Constructor;
+
+public class ReflectionUtils {
+    private ReflectionUtils() {
+        throw new PropifyException("Cannot instantiate ReflectionUtils class");
+    }
+
+    public static void makeAccessible(AccessibleObject object) {
+        if (!object.isAccessible()) {
+            object.setAccessible(true);
+        }
+    }
+
+    public static <T> Constructor<T> getDeclaredConstructor(Class<T> clazz, Class<?>... parameterTypes) {
+        try {
+            Constructor<T> constructor = clazz.getDeclaredConstructor(parameterTypes);
+            makeAccessible(constructor);
+            return constructor;
+        } catch (NoSuchMethodException e) {
+            throw new PropifyException("Failed to get constructor", e);
+        }
+    }
+
+    public static Field getDeclaredField(Class<?> clazz, String fieldName) {
+        try {
+            Field field = clazz.getDeclaredField(fieldName);
+            makeAccessible(field);
+            return field;
+        } catch (NoSuchFieldException e) {
+            throw new PropifyException("Failed to get field", e);
+        }
+    }
+
+    public static Method getDeclaredMethod(Class<?> clazz, String methodName, Class<?>... parameterTypes) {
+        try {
+            Method method = clazz.getDeclaredMethod(methodName, parameterTypes);
+            makeAccessible(method);
+            return method;
+        } catch (NoSuchMethodException e) {
+            throw new PropifyException("Failed to get method", e);
+        }
+    }
+} 
diff --git a/propify/src/main/java/com/vgerbot/propify/common/Utils.java b/propify/src/main/java/com/vgerbot/propify/common/Utils.java
@@ -29,7 +29,7 @@ public class Utils {
     )));
 
     private Utils() {
-        throw new RuntimeException("Cannot instantiate Utils class");
+        throw new PropifyException("Cannot instantiate Utils class");
     }
 
     /**
@@ -236,13 +236,12 @@ public static String[] getClassesFromAnnotationValue(AnnotationValue annotationV
                             Object type = getValueMethod.invoke(classInfo);
                             return type.toString();
                         } catch (IllegalAccessException | InvocationTargetException | NoSuchMethodException e) {
-                            throw new RuntimeException(e);
+                            throw new PropifyException("Failed to get class info", e);
                         }
                     }).toArray(String[]::new);
                 }
             } catch (NoSuchMethodException | IllegalAccessException | InvocationTargetException e) {
-                System.err.println("access javac util list error" + e.toString());
-                throw new RuntimeException(e);
+                throw new PropifyException("Failed to access javac util list", e);
             }
         }
         return new String[]{};
diff --git a/propify/src/main/java/com/vgerbot/propify/core/PropifyContext.java b/propify/src/main/java/com/vgerbot/propify/core/PropifyContext.java
@@ -5,6 +5,8 @@
 import com.vgerbot.propify.lookup.PropifyLookup;
 import com.vgerbot.propify.lookup.PropifyLookupAdaptor;
 import org.apache.commons.configuration2.interpol.Lookup;
+import com.vgerbot.propify.common.PropifyException;
+import com.vgerbot.propify.common.ReflectionUtils;
 
 import java.io.IOException;
 import java.io.InputStream;
@@ -168,12 +170,10 @@ public Map<String, Lookup> getAllLookups() {
         return Arrays.stream(this.lookups).map(it -> {
             try {
                 Class<PropifyLookup> cls = (Class<PropifyLookup>)Class.forName(it);
-                Constructor<PropifyLookup> constructor = cls.getDeclaredConstructor();
-                constructor.setAccessible(true);
+                Constructor<PropifyLookup> constructor = ReflectionUtils.getDeclaredConstructor(cls);
                 return constructor.newInstance();
-            } catch (ClassNotFoundException | InstantiationException | IllegalAccessException | NoSuchMethodException |
-                     InvocationTargetException e) {
-                throw new RuntimeException(e);
+            } catch (ClassNotFoundException | InstantiationException | IllegalAccessException | InvocationTargetException e) {
+                throw new PropifyException("Failed to instantiate lookup class", e);
             }
         }).collect(Collectors.toMap(PropifyLookup::getPrefix, PropifyLookupAdaptor::new));
     }
diff --git a/propify/src/main/java/com/vgerbot/propify/i18n/PropifyI18nResourceBundle.java b/propify/src/main/java/com/vgerbot/propify/i18n/PropifyI18nResourceBundle.java
@@ -5,6 +5,7 @@
 import java.util.concurrent.ConcurrentHashMap;
 import java.util.stream.Collectors;
 import java.util.stream.IntStream;
+import com.vgerbot.propify.common.PropifyException;
 
 public class PropifyI18nResourceBundle {
     private final String baseName;
@@ -25,7 +26,7 @@ public <T> T getMessageBundle(Class<T> type, Locale locale) {
             return Proxy.newProxyInstance(type.getClassLoader(), new Class[] { type }, (proxy, method, args) -> {
                 Message annotation = method.getAnnotation(Message.class);
                 if (annotation == null) {
-                    throw new RuntimeException(method + " is not annotated with @Message");
+                    throw new PropifyException(method + " is not annotated with @Message");
                 }
                 String keyName = annotation.key();
                 String[] arguments = annotation.arguments();
diff --git a/propify/src/test/java/com/vgerbot/propify/PropifyProcessorTest.java b/propify/src/test/java/com/vgerbot/propify/PropifyProcessorTest.java
@@ -2,6 +2,7 @@
 
 import com.vgerbot.propify.core.Propify;
 import com.vgerbot.propify.i18n.I18n;
+import com.vgerbot.propify.common.ReflectionUtils;
 import org.junit.Before;
 import org.junit.Test;
 import org.mockito.Mock;
@@ -73,10 +74,8 @@ public void setUp() {
     public void testInit() throws NoSuchFieldException, IllegalAccessException {
         // Verify that the processor was initialized correctly
         assertEquals(processingEnv, PropifyProcessor.processingEnvironment);
-        Field field = processor.getClass().getDeclaredField("messager");
-        field.setAccessible(true);
-
-        assertNotNull("Messager should be initialized", field.get(processor));
+        Field field = ReflectionUtils.getDeclaredField(PropifyProcessor.class, "messager");
+        assertEquals(messager, field.get(processor));
     }
 
     @Test

Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,7 @@`
`9`	`9`	`import com.vgerbot.propify.loader.CompileTimeResourceLoaderProvider;`
`10`	`10`	`import com.vgerbot.propify.logger.CompileTimeLogger;`
`11`	`11`	`import org.apache.commons.configuration2.Configuration;`
	`12`	`+import com.vgerbot.propify.common.PropifyException;`
`12`	`13`
`13`	`14`	`import javax.annotation.processing.*;`
`14`	`15`	`import javax.lang.model.SourceVersion;`
`@@ -138,7 +139,7 @@ public boolean process(final Set<? extends TypeElement> annotations, final Round`
`138`	`139`	`"Failed to process annotation: " + message, element);`
`139`	`140`	`}`
`140`	`141`	`} else {`
`141`		`- throw new RuntimeException(e);`
	`142`	`+ throw new PropifyException("Failed to process annotation", e);`
`142`	`143`	`}`
`143`	`144`	`}`
`144`	`145`	`}`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ public class Utils {`
`29`	`29`	`)));`
`30`	`30`
`31`	`31`	`private Utils() {`
`32`		`- throw new RuntimeException("Cannot instantiate Utils class");`
	`32`	`+ throw new PropifyException("Cannot instantiate Utils class");`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`/**`
`@@ -236,13 +236,12 @@ public static String[] getClassesFromAnnotationValue(AnnotationValue annotationV`
`236`	`236`	`Object type = getValueMethod.invoke(classInfo);`
`237`	`237`	`return type.toString();`
`238`	`238`	`} catch (IllegalAccessException \| InvocationTargetException \| NoSuchMethodException e) {`
`239`		`- throw new RuntimeException(e);`
	`239`	`+ throw new PropifyException("Failed to get class info", e);`
`240`	`240`	`}`
`241`	`241`	`}).toArray(String[]::new);`
`242`	`242`	`}`
`243`	`243`	`} catch (NoSuchMethodException \| IllegalAccessException \| InvocationTargetException e) {`
`244`		`- System.err.println("access javac util list error" + e.toString());`
`245`		`- throw new RuntimeException(e);`
	`244`	`+ throw new PropifyException("Failed to access javac util list", e);`
`246`	`245`	`}`
`247`	`246`	`}`
`248`	`247`	`return new String[]{};`