Add some ty: ignore

Author: alec-bike

altair/vegalite/v6/api.py

@@ -455,7 +455,7 @@ def to_dict(self) -> dict[str, str | dict[str, Any]]:
             return {"expr": self.name}
         elif self.param_type == "selection":
             nm: Any = self.name
-            return {"param": nm.to_dict() if hasattr(nm, "to_dict") else nm}
+            return {"param": nm.to_dict() if hasattr(nm, "to_dict") else nm}  # ty: ignore
         else:
             msg = f"Unrecognized parameter type: {self.param_type}"
             raise ValueError(msg)
@@ -648,7 +648,7 @@ def _predicate_to_condition(
     elif _is_test_predicate(predicate):
         condition = {"test": predicate}
     elif isinstance(predicate, dict):
-        condition = predicate
+        condition = predicate  # ty: ignore
     elif isinstance(predicate, _expr_core.OperatorMixin):
         condition = {"test": predicate._to_expr()}
     else:
@@ -937,7 +937,7 @@ def _when_then(
     ) -> _ConditionClosed | _Condition:
         condition: Any = _deepcopy(self._condition)
         then = _parse_then(statement, kwds)
-        condition.update(then)
+        condition.update(then)  # ty: ignore
         return condition
 
 
@@ -2149,15 +2149,15 @@ def to_dict(  # noqa: C901
                 )
                 raise ValueError(msg)
             else:
-                return _compile_with_vegafusion(vegalite_spec)
+                return _compile_with_vegafusion(vegalite_spec)  # ty: ignore
         elif format == "vega":
             plugin = vegalite_compilers.get()
             if plugin is None:
                 msg = "No active vega-lite compiler plugin found"
                 raise ValueError(msg)
             return plugin(vegalite_spec)
         else:
-            return vegalite_spec
+            return vegalite_spec  # ty: ignore
 
     def to_json(
         self,
@@ -2501,7 +2501,7 @@ def repeat(
         repeat_arg: list[str] | LayerRepeatMapping | RepeatMapping
         if repeat_specified:
             assert isinstance(repeat, list)
-            repeat_arg = repeat
+            repeat_arg = repeat  # ty: ignore
         elif layer_specified:
             repeat_arg = core.LayerRepeatMapping(layer=layer, row=row, column=column)
         else:
@@ -2764,7 +2764,7 @@ def transform_aggregate(
                 "op": parsed.get("aggregate", Undefined),
             }
             assert isinstance(aggregate, list)
-            aggregate.append(core.AggregatedFieldDef(**dct))
+            aggregate.append(core.AggregatedFieldDef(**dct))  # ty: ignore
         return self._add_transform(
             core.AggregateTransform(aggregate=aggregate, groupby=groupby)
         )
@@ -3097,7 +3097,7 @@ def transform_joinaggregate(
                 "op": parsed.get("aggregate", Undefined),
             }
             assert isinstance(joinaggregate, list)
-            joinaggregate.append(core.JoinAggregateFieldDef(**dct))
+            joinaggregate.append(core.JoinAggregateFieldDef(**dct))  # ty: ignore
         return self._add_transform(
             core.JoinAggregateTransform(joinaggregate=joinaggregate, groupby=groupby)
         )
@@ -3785,7 +3785,7 @@ def transform_window(
                         parse_types=False,
                     )
                 )
-                w.append(core.WindowFieldDef(**kwds))
+                w.append(core.WindowFieldDef(**kwds))  # ty: ignore
 
         return self._add_transform(
             core.WindowTransform(
@@ -4132,11 +4132,10 @@ def from_dict(
         jsonschema.ValidationError :
             If ``validate`` and ``dct`` does not conform to the schema
         """
-        _tp: Any
         for tp in TopLevelMixin.__subclasses__():
-            _tp = super() if tp is Chart else tp
+            _tp: Any = super() if tp is Chart else tp
             try:
-                return _tp.from_dict(dct, validate=validate)
+                return _tp.from_dict(dct, validate=validate)  # ty: ignore
             except jsonschema.ValidationError:
                 pass
 

altair/vegalite/v6/data.py

@@ -24,7 +24,7 @@
 data_transformers.register("default", default_data_transformer)
 data_transformers.register("json", to_json)
 # FIXME: `to_csv` cannot accept all `DataType` https://github.com/vega/altair/issues/3441
-data_transformers.register("csv", to_csv)  # type: ignore[arg-type]
+data_transformers.register("csv", to_csv)  # type: ignore
 data_transformers.register("vegafusion", vegafusion_data_transformer)
 data_transformers.enable("default")
 

ty.toml

@@ -5,20 +5,15 @@ exclude = ["altair/vegalite/v6/schema"]
 [rules]
 unused-type-ignore-comment = "ignore"  # skip unused type: ignore
 deprecated = "ignore"
-# flag these until resolved, ~20 errors
+# flag these until resolved
 # invalid-overload = "ignore"  # 700+ errors in v6/schema
 # unresolved-attribute = "ignore"  # 80+ errors in v6/schema
-# invalid-argument-type = "ignore"  # ~10 errors
-# invalid-return-type = "ignore"
-# not-subscriptable = "ignore"
-# call-non-callable = "ignore"
+# invalid-argument-type = "ignore"
 # invalid-assignment = "ignore"
-# unresolved-import = "ignore"
-# missing-argument = "ignore"
-# no-matching-overload = "ignore"
-# invalid-context-manager = "ignore"
-# invalid-method-override = "ignore"
-# invalid-super-argument = "ignore"
+# invalid-return-type = "ignore"
+no-matching-overload = "ignore"
+invalid-context-manager = "ignore"
+invalid-method-override = "ignore"
 
 [analysis]
 respect-type-ignore-comments = true  # allow existing type: ignore