Problematic load-secrets is excessively terse

[mbaldessari]

When there is a problem in the yaml containing secrets, for example like this:

diff --git a/values-secret.yaml.template b/values-secret.yaml.template
index c068200f..7f4b66e3 100644
--- a/values-secret.yaml.template
+++ b/values-secret.yaml.template
@@ -8,7 +8,7 @@ version: "2.0"
 # automatically generated inside the vault this should not really matter)
 
 secrets:
-  - name: config-demo
+  - names: config-demo
     vaultPrefixes:
     - global
     fields:

we error out like this:

❯ ./pattern.sh make load-secrets
[WARNING]: No inventory was parsed, only implicit localhost is available
[WARNING]: Collection community.general does not support Ansible version 2.16.14
==> Loading secrets (this may take several minutes)...
make: *** [Makefile-common:33: load-secrets] Error 2

We should try and be a bit more useful

[mbaldessari]

At the very list we need to print which files we are working on by default:

TASK [rhvp.cluster_utils.find_vp_secrets : Is found values secret file encrypted] **********************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************
ok: [localhost] => {
    "msg": "Using /home/michele/Engineering/cloud-patterns/multicloud-gitops/values-secret.yaml.template to parse secrets"
}

[dminnear-rh]

You're able to control the ansible output: https://validatedpatterns.io/blog/2025-08-29-new-common-makefile-structure/#_how_commands_are_executed

ANSIBLE_STDOUT_CALLBACK=default EXTRA_PLAYBOOK_OPTS='-e hide_sensitive_output="false" -vvv' ./pattern.sh make load-secrets

By default, ANSIBLE_STDOUT_CALLBACK is set to null since it's not terribly useful when everything is working but as you've experienced it's very useful when things aren't working.

I'm open to better solutions than just rerunning with more verbosity though. I also still need to add display-secrets-info which should make debugging secrets easier as well.

[mbaldessari]

Yeah I was aware of those. I wonder if we can at least print the secrets template it is using and maybe throw in a command example if things error out?

[mbaldessari]

So whenever we fail we should suggest that the user can run something likeANSIBLE_STDOUT_CALLBACK=default EXTRA_PLAYBOOK_OPTS="-vvv -e hide_sensitive_output=false" ./pattern.sh make load-secrets

[mbaldessari]

We fixed that with the new outputs so closing