workflows: fix version propagation through workflow

Author: LeoKle

.github/actions/version/action.yml

@@ -8,6 +8,11 @@ inputs:
     description: "The Git reference (branch/tag) to check"
     required: true
 
+outputs:
+  version:
+    description: "The determined version"
+    value: ${{ steps.version_handler.outputs.version }}
+
 runs:
   using: "composite"
   steps:
@@ -34,11 +39,6 @@ runs:
       run: |
         python .github/workflows/version_handler.py
 
-      # Set the output VERSION from the result of the script
-    - name: Set version output
-      shell: bash
-      run: echo "VERSION=${{ steps.version_handler.outputs.version }}" >> $GITHUB_ENV
-
     - name: Fail if version is 0
       shell: bash
       run: |

.github/workflows/build-develop2.yml

@@ -15,6 +15,7 @@ jobs:
         uses: actions/checkout@v3
 
       - name: Get latest release version
+        id: version_check
         uses: ./.github/actions/version
         with:
           repository: ${{ github.repository }}
@@ -37,6 +38,6 @@ jobs:
         uses: ./.github/actions/release
         with:
           build-config: ${{env.BUILD_CONFIGURATION}}
-          version-name: ${{env.VERSION}}
+          version-name: ${{steps.version_check.outputs.version}}
           prelease: true
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/version_handler.py

@@ -1,5 +1,3 @@
-""" """
-
 import sys
 import os
 import re
@@ -10,13 +8,13 @@
 REPOSITORY_NAME = os.environ.get("REPOSITORY")
 REF = os.environ.get("REF")
 
-# determine the branch that triggered the workflow
+# Determine the branch that triggered the workflow
 match = re.match(r"refs/heads/(.*)", REF)
 if not match:
     sys.exit(1)
 
 branch_name = match.group(1)
-print("Determined branch name: ", branch_name)
+print(f"Determined branch name: {branch_name}")
 
 version = extract_version_from_cmakelists()
 
@@ -25,12 +23,20 @@
 if is_dev_branch:
     last_dev_release = determine_dev_release(version, REPOSITORY_NAME)
     dev_release = str(last_dev_release + 1)
-    version += "-dev." + dev_release
+    version += f"-dev.{dev_release}"
+
+# Ensure GITHUB_OUTPUT is set correctly
+github_output = os.getenv("GITHUB_OUTPUT")
+if not github_output:
+    print("Error: GITHUB_OUTPUT is not set!", file=sys.stderr)
+    sys.exit(1)
 
-# Write the version and dev release to GitHub environment variable
-with open(os.getenv("GITHUB_OUTPUT"), "a", encoding="utf-8") as env_file:
-    env_file.write(f"VERSION={version}\n")
-    print(f"VERSION={version}")
+# Write the outputs correctly
+with open(github_output, "a", encoding="utf-8") as env_file:
+    env_file.write(f"version={version}\n")
+    print(
+        f"::set-output name=version::{version}"
+    )  # Deprecated, but useful for debugging
     if is_dev_branch and dev_release:
-        print(f"DEV_RELEASE={dev_release}")
-        env_file.write(f"DEV_RELEASE={dev_release}\n")
+        env_file.write(f"dev_release={dev_release}\n")
+        print(f"::set-output name=dev_release::{dev_release}")