Skip to content

Backlog/fix/tag rules#2106

Merged
osmontero merged 3 commits into
release/v11.2.9from
backlog/fix/tag_rules
May 29, 2026
Merged

Backlog/fix/tag rules#2106
osmontero merged 3 commits into
release/v11.2.9from
backlog/fix/tag_rules

Conversation

@AlexSanchez-bit

Copy link
Copy Markdown
Contributor

Main Changes

  • removed the max 50 post events on rule creation validation
  • added related events fields on tagging rules

@AlexSanchez-bit AlexSanchez-bit requested a review from a team May 27, 2026 04:52
@github-actions

github-actions Bot commented May 27, 2026

Copy link
Copy Markdown

❌ Go dependencies check failed

There are outdated Go dependencies, or modules that could not be inspected.
Run bash .github/scripts/go-deps.sh --update --discover locally and
commit the updated go.mod / go.sum files.

Script output
🔍 Discovered 25 Go projects

📦 Dependencies with updates available:

  📁 ./installer:
     - github.com/cloudfoundry/gosigar: v1.3.119 → v1.3.120

  📁 ./plugins/modules-config:
     - github.com/aws/aws-sdk-go-v2/config: v1.32.17 → v1.32.19
     - github.com/aws/aws-sdk-go-v2/credentials: v1.19.16 → v1.19.18
     - github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs: v1.74.0 → v1.74.1
     - github.com/aws/aws-sdk-go-v2/service/sts: v1.42.1 → v1.42.2
     - google.golang.org/api: v0.280.0 → v0.282.0

  📁 ./plugins/aws:
     - github.com/aws/aws-sdk-go-v2: v1.41.7 → v1.41.8
     - github.com/aws/aws-sdk-go-v2/config: v1.32.17 → v1.32.19
     - github.com/aws/aws-sdk-go-v2/credentials: v1.19.16 → v1.19.18
     - github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs: v1.74.0 → v1.74.1

  📁 ./plugins/gcp:
     - google.golang.org/api: v0.280.0 → v0.282.0

  📁 ./agent:
     - golang.org/x/sys: v0.44.0 → v0.45.0

�[0;31m❌ Please update dependencies before merging.�[0m

@github-actions

github-actions Bot commented May 27, 2026

Copy link
Copy Markdown

⚠️ AI review — Changes requested

One or more prompts found issues the author should fix before merging. Details below.

architecture (gemini-3-flash-lite) — Tier 1 — looks clean

Summary: Frontend-only changes to alert rule configuration and validation limits; no impact on backend, agent, or API contracts.

No findings.

⚠️ bugs (gemini-3-flash-lite) — Tier 2 — changes requested

Summary: Potential logic error in event field resolution and missing null checks in AlertRuleCreateComponent

  • medium frontend/src/app/data-management/alert-management/shared/components/alert-rule-create/alert-rule-create.component.ts:236 — The logic this.alert.events[0] assumes that if an alert has events, the condition should only be evaluated against the first event. This will cause incorrect filtering/matching if the rule is intended to apply to any event in the array.
  • medium frontend/src/app/data-management/alert-management/shared/components/alert-rule-create/alert-rule-create.component.ts:236 — Potential runtime error: field.split('.') is called without verifying that the field string contains a dot, which may lead to unexpected behavior when fields.splice(0, 1) is executed.

⚠️ security (gemini-3-flash-lite) — Tier 2 — changes requested

Summary: Potential prototype pollution or unsafe property access in getFieldValue; increased event count limit.

  • medium frontend/src/app/data-management/alert-management/shared/components/alert-rule-create/alert-rule-create.component.ts:235 — The manual splitting and joining of the 'field' string to access nested properties on 'this.alert.events[0]' may be vulnerable to prototype pollution or unexpected object traversal if the input is not strictly sanitized.

@utmstackprapprover utmstackprapprover Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested — see approver comments above.

@osmontero osmontero merged commit c2fc584 into release/v11.2.9 May 29, 2026
2 checks passed
@osmontero osmontero deleted the backlog/fix/tag_rules branch May 29, 2026 14:10

@utmstackprapprover utmstackprapprover Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested — see approver comments above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants