Skip to content

fix[frontend](socai): added default template for empty previous socai config#2093

Closed
AlexSanchez-bit wants to merge 1 commit into
release/v11.2.9from
hotfix/socai
Closed

fix[frontend](socai): added default template for empty previous socai config#2093
AlexSanchez-bit wants to merge 1 commit into
release/v11.2.9from
hotfix/socai

Conversation

@AlexSanchez-bit

Copy link
Copy Markdown
Contributor

Main chages

previously an already defined configuratio was needed for getting config kays, data types, now a default template for newly created data is setted up so updates can work even if there's no module group on database

@AlexSanchez-bit AlexSanchez-bit requested a review from a team May 21, 2026 21:47
@github-actions

Copy link
Copy Markdown

❌ Go dependencies check failed

There are outdated Go dependencies, or modules that could not be inspected.
Run bash .github/scripts/go-deps.sh --update --discover locally and
commit the updated go.mod / go.sum files.

Script output
🔍 Discovered 25 Go projects

📦 Dependencies with updates available:

  📁 ./agent:
     - golang.org/x/sys: v0.44.0 → v0.45.0

�[0;31m❌ Please update dependencies before merging.�[0m

@github-actions

Copy link
Copy Markdown

🛑 AI review — Engineer review required

This PR touches critical paths or introduces changes the model cannot judge with sufficient confidence. @Kbayero @osmontero please review.

⚠️ architecture (gemini-3-flash-lite) — Tier 2 — changes requested

Summary: Frontend UI update to include data types in configuration changes; no architectural impact on backend or agents.

  • low frontend/src/app/app-module/guides/guide-soc-ai/guide-soc-ai.component.ts:492 — The pushChange method signature change is a structural improvement for type safety, but ensure that the new 'confDataType' parameter is consistently handled by the backend API to avoid validation errors.

⚠️ bugs (gemini-3-flash-lite) — Tier 2 — changes requested

Summary: Added logic to push new configuration keys in pushChange, but the implementation lacks error handling for the subscription and potential state issues.

  • medium frontend/src/app/app-module/guides/guide-soc-ai/guide-soc-ai.component.ts:300 — The subscription in loadConfig lacks an error handler. If the API call fails, the finalize block will still execute, but the component state may remain in an inconsistent or error-prone state.

🛑 security (gemini-3-flash-lite) — Tier 3 — engineer review required

Summary: Improper handling of API keys and sensitive configuration data in SOC AI integration.

  • high frontend/src/app/app-module/guides/guide-soc-ai/guide-soc-ai.component.ts:467 — API keys are being passed to pushChange with 'text' type instead of 'password'. This causes sensitive credentials to be stored as plain text in the database and potentially exposed in UI logs or browser storage. Mitigation: Use 'password' as the confDataType for API keys.
  • medium frontend/src/app/app-module/guides/guide-soc-ai/guide-soc-ai.component.ts:467 — Sensitive authentication headers containing API keys are being serialized into JSON and stored as 'text'. This increases the risk of credential exposure. Mitigation: Ensure sensitive configuration fields are marked as 'password' and handled securely by the backend.

@utmstackprapprover utmstackprapprover Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested — see approver comments above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant