v3.6.2 adds empty line to stderr when cli.Exit is called with empty message

[mustafabayar]

My urfave/cli version is

v3.3.3

Checklist

• Are you running the latest v3 release? The list of releases is here.
• Did you check the manual for your release? The v3 manual is here
• Did you perform a search about this problem? Here's the GitHub guide about searching.

Dependency Management

• My project is using go modules.

Describe the bug

The change from #2237 that is released in version v3.6.2 causes empty line to be added to stderr if cli.Exit is called with an empty message such as:

cli.Exit("", exitError.ExitCode())

To reproduce

cli.Exit("", exitError.ExitCode())

Observed behavior

Our test assertions are now broken due to unnecessary empty line in the output.

Expected behavior

I want to understand if this was intentional, because Exit accepts empty string as valid input. I believe it should either not accept it, or not add unnecessary empty lines.

[dearchap]

@mustafabayar Yes that change was intentional. It seems to have had an unintended side effect that you mention.