Fix cicd - clang-tidy should run after build success

Author: urbytes21

.github/workflows/cpp-build-test-coverage.yml

@@ -57,26 +57,7 @@ jobs:
                    --inline-suppr \
                    --error-exitcode=1 \
                    ./src ./include
-
-      # -------------------------------------------------------
-      # Step 2.1: Run Clang-Tidy (experimenting , not exit)
-      # - Modern C++ static analysis
-      # - Enforces best practices
-      # - Add `--warnings-as-errors=*` to exit code 1
-      # -------------------------------------------------------
-      - name: Run clang-tidy
-        # run: |
-        #   echo "Running clang-tidy..."
-        #   clang-tidy \
-        #     -checks='clang-analyzer-*,modernize-*,performance-*,readability-*' \
-        #     -p build \
-        #     $(find ./src -name '*.cpp')
-        run: |
-            echo "Running clang-tidy using .clang-tidy options"
-            clang-tidy \
-              -p build \
-              -header-filter='^src/.*' $(find src -name "*.cpp")
-      
+    
       # -------------------------------------------------------
       # Step 3: Configure and build the project
       # -------------------------------------------------------
@@ -116,3 +97,22 @@ jobs:
           cd build
           echo "## Test Coverage Summary" >> $GITHUB_STEP_SUMMARY
           lcov --summary coverageFiltered.info >> $GITHUB_STEP_SUMMARY
+
+      # -------------------------------------------------------
+      # Step 7: Run Clang-Tidy (experimenting , not exit)
+      # - Modern C++ static analysis
+      # - Enforces best practices
+      # - Add `--warnings-as-errors=*` to exit code 1
+      # -------------------------------------------------------
+      - name: Run clang-tidy
+        # run: |
+        #   echo "Running clang-tidy..."
+        #   clang-tidy \
+        #     -checks='clang-analyzer-*,modernize-*,performance-*,readability-*' \
+        #     -p build \
+        #     $(find ./src -name '*.cpp')
+        run: |
+            echo "Running clang-tidy using .clang-tidy options"
+            clang-tidy \
+              -p build \
+              -header-filter='^src/.*' $(find src -name "*.cpp")